Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] "Use email instead" crashes fenix in Romanian language #9698

Closed
rpappalax opened this issue Apr 3, 2020 · 3 comments
Closed

[Bug] "Use email instead" crashes fenix in Romanian language #9698

rpappalax opened this issue Apr 3, 2020 · 3 comments
Assignees
@mcarare
Labels
b:crash Crashes Fenix: should link to Sentry, Crash-Stats or GPlay info 🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Sync

Comments

@rpappalax
Copy link
Contributor

rpappalax commented Apr 3, 2020 •
edited by data-sync-user

Steps to reproduce

Set default device language to Romanian

  1. Open Fenix
  2. Click on "Autentificare în Firefox" (Sign in to Firefox)
  3. Click on "Folosește e-mail-ul în schimb" (Use email instead)

Expected behavior

  1. Redirect to "Enter your email to continue to Firefox Sync" page

Actual behavior

  1. Application crashes: "Firefox Preview has stopped"

Note:
This feature works fine using English and Italian languages

Device information

  • Android device: Galaxy S8, Android 8.0.0
  • Fenix version: 4.2.1 (Build #20941431)
04-03 14:20:59.445   634   634 E hw-IPCThreadState: binder thread pool (1 threads) starved for 108 ms
04-03 14:21:05.829   634   634 E hw-IPCThreadState: binder thread pool (1 threads) starved for 118 ms
04-03 14:21:12.177   634   634 E hw-IPCThreadState: binder thread pool (1 threads) starved for 114 ms
04-03 14:21:15.408   634   634 E hw-IPCThreadState: binder thread pool (1 threads) starved for 102 ms
04-03 14:21:27.681 27669 27669 E AndroidRuntime: FATAL EXCEPTION: main
04-03 14:21:27.681 27669 27669 E AndroidRuntime: Process: org.mozilla.fenix, PID: 27669
04-03 14:21:27.681 27669 27669 E AndroidRuntime: java.lang.RuntimeException: Unable to start activity ComponentInfo{org.mozilla.fenix/org.mozilla.fenix.settings.account.AuthCustomTabActivity}: java.util.UnknownFormatConversionException: Conversion = '&'
04-03 14:21:27.681 27669 27669 E AndroidRuntime: 	at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2955)
04-03 14:21:27.681 27669 27669 E AndroidRuntime: 	at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:3030)
04-03 14:21:27.681 27669 27669 E AndroidRuntime: 	at android.app.ActivityThread.-wrap11(Unknown Source:0)
04-03 14:21:27.681 27669 27669 E AndroidRuntime: 	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1696)
04-03 14:21:27.681 27669 27669 E AndroidRuntime: 	at android.os.Handler.dispatchMessage(Handler.java:105)
04-03 14:21:27.681 27669 27669 E AndroidRuntime: 	at android.os.Looper.loop(Looper.java:164)
04-03 14:21:27.681 27669 27669 E AndroidRuntime: 	at android.app.ActivityThread.main(ActivityThread.java:6938)
04-03 14:21:27.681 27669 27669 E AndroidRuntime: 	at java.lang.reflect.Method.invoke(Native Method)
04-03 14:21:27.681 27669 27669 E AndroidRuntime: 	at com.android.internal.os.Zygote$MethodAndArgsCaller.run(Zygote.java:327)
04-03 14:21:27.681 27669 27669 E AndroidRuntime: 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1374)
04-03 14:21:27.681 27669 27669 E AndroidRuntime: Caused by: java.util.UnknownFormatConversionException: Conversion = '&'
04-03 14:21:27.681 27669 27669 E AndroidRuntime: 	at java.util.Formatter$FormatSpecifier.conversion(Formatter.java:2781)
04-03 14:21:27.681 27669 27669 E AndroidRuntime: 	at java.util.Formatter$FormatSpecifier.<init>(Formatter.java:2811)
04-03 14:21:27.681 27669 27669 E AndroidRuntime: 	at java.util.Formatter$FormatSpecifierParser.<init>(Formatter.java:2624)
04-03 14:21:27.681 27669 27669 E AndroidRuntime: 	at java.util.Formatter.parse(Formatter.java:2557)
04-03 14:21:27.681 27669 27669 E AndroidRuntime: 	at java.util.Formatter.format(Formatter.java:2504)
04-03 14:21:27.681 27669 27669 E AndroidRuntime: 	at java.util.Formatter.format(Formatter.java:2458)
04-03 14:21:27.681 27669 27669 E AndroidRuntime: 	at java.lang.String.format(String.java:2814)
04-03 14:21:27.681 27669 27669 E AndroidRuntime: 	at android.content.res.Resources.getString(Resources.java:472)
04-03 14:21:27.681 27669 27669 E AndroidRuntime: 	at android.content.Context.getString(Context.java:572)
04-03 14:21:27.681 27669 27669 E AndroidRuntime: 	at org.mozilla.fenix.customtabs.CustomTabToolbarMenu.<init>(CustomTabToolbarMenu.kt:21)
04-03 14:21:27.681 27669 27669 E AndroidRuntime: 	at org.mozilla.fenix.components.toolbar.BrowserToolbarView.<init>(BrowserToolbarView.kt:72)
04-03 14:21:27.681 27669 27669 E AndroidRuntime: 	at org.mozilla.fenix.browser.BaseBrowserFragment.initializeUI(BaseBrowserFragment.kt:57)
04-03 14:21:27.681 27669 27669 E AndroidRuntime: 	at org.mozilla.fenix.customtabs.ExternalAppBrowserFragment.initializeUI(ExternalAppBrowserFragment.kt:1)
04-03 14:21:27.681 27669 27669 E AndroidRuntime: 	at org.mozilla.fenix.browser.BaseBrowserFragment.onViewCreated(BaseBrowserFragment.kt:1)
04-03 14:21:27.681 27669 27669 E AndroidRuntime: 	at androidx.fragment.app.FragmentManager.moveToState(FragmentManager.java:94)
04-03 14:21:27.681 27669 27669 E AndroidRuntime: 	at androidx.fragment.app.FragmentManager.addAddedFragments(FragmentManager.java:5)
04-03 14:21:27.681 27669 27669 E AndroidRuntime: 	at androidx.fragment.app.FragmentManager.executeOpsTogether(FragmentManager.java:54)
04-03 14:21:27.681 27669 27669 E AndroidRuntime: 	at androidx.fragment.app.FragmentManager.removeRedundantOperationsAndExecute(FragmentManager.java:11)
04-03 14:21:27.681 27669 27669 E AndroidRuntime: 	at androidx.fragment.app.FragmentManager.execPendingActions(FragmentManager.java:4)
04-03 14:21:27.681 27669 27669 E AndroidRuntime: 	at androidx.fragment.app.FragmentManager.dispatchStateChange(FragmentManager.java:5)
04-03 14:21:27.681 27669 27669 E AndroidRuntime: 	at androidx.fragment.app.Fragment.performActivityCreated(Fragment.java:9)
04-03 14:21:27.681 27669 27669 E AndroidRuntime: 	at androidx.fragment.app.FragmentManager.moveToState(FragmentManager.java:99)
04-03 14:21:27.681 27669 27669 E AndroidRuntime: 	at androidx.fragment.app.FragmentManager.moveFragmentToExpectedState(FragmentManager.java:4)
04-03 14:21:27.681 27669 27669 E AndroidRuntime: 	at androidx.fragment.app.FragmentManager.moveToState(FragmentManager.java:218)
04-03 14:21:27.681 27669 27669 E AndroidRuntime: 	at androidx.fragment.app.FragmentManager.dispatchStateChange(FragmentManager.java:3)
04-03 14:21:27.681 27669 27669 E AndroidRuntime: 	at androidx.fragment.app.FragmentActivity.onStart(FragmentActivity.java:9)
04-03 14:21:27.681 27669 27669 E AndroidRuntime: 	at androidx.appcompat.app.AppCompatActivity.onStart(AppCompatActivity.java:1)
04-03 14:21:27.681 27669 27669 E AndroidRuntime: 	at android.app.Instrumentation.callActivityOnStart(Instrumentation.java:1340)
04-03 14:21:27.681 27669 27669 E AndroidRuntime: 	at android.app.Activity.performStart(Activity.java:7200)
04-03 14:21:27.681 27669 27669 E AndroidRuntime: 	at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2918)
04-03 14:21:27.681 27669 27669 E AndroidRuntime: 	... 9 more
04-03 14:21:27.775  6225  6225 E Zygote  : isWhitelistProcess - Process is Whitelisted
04-03 14:21:27.782  3356  3440 E PhoneWindow_APM : : sendNotificationForAppPermissionMonitor callingPid = 3356, uid = 1000
04-03 14:21:27.782  3356  3440 E PhoneWindow_APM : : sendNotificationForAppPermissionMonitor 2
04-03 14:21:27.782  3356  3440 E PhoneWindow_APM : : sendNotificationForAppPermissionMonitor 21000_3356
04-03 14:21:27.782  3356  3440 E PhoneWindow_APM : : isCalledPackage return false
04-03 14:21:27.782  3356  3440 E PhoneWindow_APM : : sendNotificationForAppPermissionMonitor mIsMonitoredFeature = true
04-03 14:21:27.844  6242  6242 E Zygote  : isWhitelistProcess - Process is Whitelisted
04-03 14:21:27.870  3053  3053 E audit   : type=1400 audit(1585948887.852:32244): ```

┆Issue is synchronized with this [Jira Task](https://mozilla-hub.atlassian.net/browse/FNXV2-16652)
@rpappalax rpappalax added 🐞 bug Crashes, Something isn't working, .. b:crash Crashes Fenix: should link to Sentry, Crash-Stats or GPlay info Feature:Sync labels Apr 3, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Apr 3, 2020
@mcarare
Copy link
Contributor

mcarare commented Apr 6, 2020

I've checked the strings in 4.2.1 and there seems to be a problem with the text from translation. It has been corrected since, but still, we should add a way to handle this in the future.

@mcarare mcarare self-assigned this Apr 6, 2020
mcarare added a commit to mcarare/fenix that referenced this issue Apr 6, 2020
@mcarare
For mozilla-mobile#9698: Add Context extension to avoid format Illega…
1246e3c 
…lArgumentException
mcarare added a commit to mcarare/fenix that referenced this issue Apr 6, 2020
@mcarare
For mozilla-mobile#9698: Use extension to ensure fallback to English …
f4c3407 
…and void crash
mcarare added a commit to mcarare/fenix that referenced this issue Apr 7, 2020
@mcarare
For mozilla-mobile#9698: Add Context extension to avoid format Illega…
257338b 
…lArgumentException
mcarare added a commit to mcarare/fenix that referenced this issue Apr 7, 2020
@mcarare
For mozilla-mobile#9698: Add Context extension to avoid format Illega…
de7e01f 
…lArgumentException
mcarare added a commit to mcarare/fenix that referenced this issue Apr 7, 2020
@mcarare
For mozilla-mobile#9698: Use extension to ensure fallback to English …
ccc7e0a 
…and void crash
mcarare added a commit to mcarare/fenix that referenced this issue Apr 7, 2020
@mcarare
For mozilla-mobile#9698: Add Context extension to avoid format Illega…
504ae36 
…lArgumentException
mcarare added a commit to mcarare/fenix that referenced this issue Apr 7, 2020
@mcarare
For mozilla-mobile#9698: Use extension to ensure fallback to English …
3370e6b 
…and void crash
mcarare added a commit to mcarare/fenix that referenced this issue Apr 7, 2020
@mcarare
For mozilla-mobile#9698: Add Context extension to avoid format Illega…
840b708 
…lArgumentException
mcarare added a commit to mcarare/fenix that referenced this issue Apr 7, 2020
@mcarare
For mozilla-mobile#9698: Add Context extension to avoid format Illega…
4457e0f 
…lArgumentException
mcarare added a commit to mcarare/fenix that referenced this issue Apr 7, 2020
@mcarare
For mozilla-mobile#9698: Use extension to ensure fallback to English …
565dd7f 
…and void crash
mcarare added a commit to mcarare/fenix that referenced this issue Apr 7, 2020
@mcarare
For mozilla-mobile#9698: Add Context extension to avoid format Illega…
229f886 
…lArgumentException
mcarare added a commit to mcarare/fenix that referenced this issue Apr 7, 2020
@mcarare
For mozilla-mobile#9698: Add Context extension to avoid format Illega…
122ac4f 
…lArgumentException
mcarare added a commit to mcarare/fenix that referenced this issue Apr 7, 2020
@mcarare
For mozilla-mobile#9698: Use extension to ensure fallback to English …
53fc6cb 
…and void crash
mcarare added a commit to mcarare/fenix that referenced this issue Apr 7, 2020
@mcarare
For mozilla-mobile#9698: Add unit tests for Context extension getStri…
9f1c72e 
…ngWithArgSafe
mcarare added a commit to mcarare/fenix that referenced this issue Apr 7, 2020
@mcarare
For mozilla-mobile#9698: Use extension to ensure fallback to English …
72a17cd 
…and avoid crash
mcarare added a commit to mcarare/fenix that referenced this issue Apr 7, 2020
@mcarare
For mozilla-mobile#9698: Add unit tests for Context extension getStri…
8e915d2 
…ngWithArgSafe
@sflorean
Copy link
Contributor

sflorean commented Apr 7, 2020

Tested also with Francais, Espaniol, Deutsch, one RTL language and Chinese, and couldn't reproduce the crash, on 4.2.1 Build.
On Nightly, 04/07 the issue is not reproducible with the Romanian language set.

mcarare added a commit that referenced this issue Apr 13, 2020
@mcarare
For #9698: Add Context extension to avoid format IllegalArgumentExcep…
4a1a875 
…tion
mcarare added a commit that referenced this issue Apr 13, 2020
@mcarare
For #9698: Use extension to ensure fallback to English and avoid crash
a214f04
mcarare added a commit that referenced this issue Apr 13, 2020
@mcarare
For #9698: Add unit tests for Context extension getStringWithArgSafe
8cdc523
@mcarare mcarare added the eng:qa:needed QA Needed label Apr 13, 2020
@liuche liuche mentioned this issue Apr 13, 2020
Closed
32 tasks
liuche pushed a commit that referenced this issue Apr 13, 2020
@mcarare @liuche
For #9698: Add Context extension to avoid format IllegalArgumentExcep…
c0fdc7f 
…tion
liuche pushed a commit that referenced this issue Apr 13, 2020
@mcarare @liuche
For #9698: Use extension to ensure fallback to English and avoid crash
dac576f
liuche pushed a commit that referenced this issue Apr 13, 2020
@mcarare @liuche
For #9698: Add unit tests for Context extension getStringWithArgSafe
e153642
@sflorean
Copy link
Contributor

Verified as fixed on 4.3.0-beta.1 with Samsung Galaxy Note 10 (Android 10) and Nokia 6 (Android 7.1.1). Checked as well on Nightly (the issue wasn't reproducible) and the crash is not encountered.

@sflorean sflorean added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Apr 14, 2020
@ekager ekager removed the needs:triage Issue needs triage label Apr 17, 2020
@liuche liuche mentioned this issue Apr 28, 2020
Closed
32 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mcarare mcarare

Labels
b:crash Crashes Fenix: should link to Sentry, Crash-Stats or GPlay info 🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Sync
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@rpappalax @ekager @mcarare @sflorean