Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

simplify nav graph #9751

Closed
boek opened this issue Apr 6, 2020 · 0 comments · Fixed by #9829
Closed

simplify nav graph #9751

boek opened this issue Apr 6, 2020 · 0 comments · Fixed by #9829
Assignees
@boek
Labels
E8 Estimation Point: about 8 days Feature:Tabs
Projects
Tabs Tray Refactor Tabs Tray

Comments

@boek
Copy link
Contributor

boek commented Apr 6, 2020 •
edited by data-sync-user
Loading

Our nav graph is getting huge. We should use some of the tools they give us to tame it

┆Issue is synchronized with this Jira Task
@boek boek self-assigned this Apr 6, 2020
@boek boek added this to In progress in Tabs Tray Refactor Apr 6, 2020
@boek boek added this to In Progress in Fenix Sprint Kanban Apr 6, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Apr 6, 2020
boek added a commit to boek/fenix that referenced this issue Apr 8, 2020
@boek
For mozilla-mobile#9751 - Cleans up homeFragment directions
b6bd725
boek added a commit to boek/fenix that referenced this issue Apr 8, 2020
@boek
For mozilla-mobile#9751 - Uses global actions for fragments not owned…
b1f879e 
… by homeFragment
boek added a commit to boek/fenix that referenced this issue Apr 8, 2020
@boek
For mozilla-mobile#9751 - Cleans up SearchFragment directions
9178e49
boek added a commit to boek/fenix that referenced this issue Apr 8, 2020
@boek
For mozilla-mobile#9751 - Removes settings action from DeleteBrowsing…
6d32675 
…DataFragment
boek added a commit to boek/fenix that referenced this issue Apr 8, 2020
@boek
For mozilla-mobile#9751 - Removes browser action from SettingsFragment
f3aa247
boek added a commit to boek/fenix that referenced this issue Apr 8, 2020
@boek
For mozilla-mobile#9751 - Adds ManagePhoneFeature global action
6f73452
boek added a commit to boek/fenix that referenced this issue Apr 8, 2020
@boek
For mozilla-mobile#9751 - Clean up unused deletebrowsingfragment actions
a7434e1
boek added a commit to boek/fenix that referenced this issue Apr 8, 2020
@boek
For mozilla-mobile#9751 - Cleans Up HistoryFragment actions
c784a03
boek added a commit to boek/fenix that referenced this issue Apr 8, 2020
@boek
For mozilla-mobile#9751 - Removes Home -> Search action
2a930d4
boek added a commit to boek/fenix that referenced this issue Apr 8, 2020
@boek
For mozilla-mobile#9751 - Removes the Bookmark -> Browser action
6e60ddd
boek added a commit to boek/fenix that referenced this issue Apr 8, 2020
@boek
For mozilla-mobile#9751 - Cleans up bookmark fragment actions
53f956f
boek added a commit to boek/fenix that referenced this issue Apr 8, 2020
@boek
For mozilla-mobile#9751 - Cleans up actions from ShareController
ae9c9a6
boek added a commit to boek/fenix that referenced this issue Apr 8, 2020
@boek
For mozilla-mobile#9751 - Removes defaultBrowserFragment to browserFr…
a9d4c08 
…agment action
boek added a commit to boek/fenix that referenced this issue Apr 8, 2020
@boek
For mozilla-mobile#9751 - Removes about -> browser action
542fb98
boek added a commit to boek/fenix that referenced this issue Apr 8, 2020
@boek
For mozilla-mobile#9751 - Adds global action to TrackingProtectionFra…
401a021 
…gment
boek added a commit to boek/fenix that referenced this issue Apr 8, 2020
@boek
For mozilla-mobile#9751 - Removes exception -> browser action
de818dd
boek added a commit to boek/fenix that referenced this issue Apr 8, 2020
@boek
For mozilla-mobile#9751 - Removes login -> browser action
290a47e
boek added a commit to boek/fenix that referenced this issue Apr 8, 2020
@boek
For mozilla-mobile#9751 - Fixes LoginFragment directions
9f66528
boek added a commit to boek/fenix that referenced this issue Apr 8, 2020
@boek
For mozilla-mobile#9751 - Removes ExternalAppBrowser directions
5864e79
boek added a commit to boek/fenix that referenced this issue Apr 9, 2020
@boek
for mozilla-mobile#9751 - Cleans up actions
af5ca89
boek added a commit to boek/fenix that referenced this issue Apr 9, 2020
@boek
for mozilla-mobile#9751 - Cleans up actions
bdfc6d5
boek added a commit to boek/fenix that referenced this issue Apr 9, 2020
@boek
For mozilla-mobile#9751 - Fixes unit tests
341f9fb
boek added a commit to boek/fenix that referenced this issue Apr 9, 2020
@boek
For mozilla-mobile#9751 - Fixes unit tests
781c777
boek added a commit to boek/fenix that referenced this issue Apr 10, 2020
@boek
For mozilla-mobile#9751 - Fixes unit tests
7681b95
boek added a commit to boek/fenix that referenced this issue Apr 10, 2020
@boek
For mozilla-mobile#9751 - Fixes unit tests
90735dc
boek added a commit to boek/fenix that referenced this issue Apr 10, 2020
@boek
For mozilla-mobile#9751 - Fixes unit tests
ecacaf6
boek added a commit to boek/fenix that referenced this issue Apr 13, 2020
@boek
For mozilla-mobile#9751 - Addresses nits in PR
4d9d045
boek added a commit to boek/fenix that referenced this issue Apr 13, 2020
@boek
For mozilla-mobile#9751 - Addresses nits in PR
403231f
boek added a commit to boek/fenix that referenced this issue Apr 14, 2020
@boek
For mozilla-mobile#9751 - Addresses nits in PR
f83a608
boek added a commit that referenced this issue Apr 14, 2020
@boek
Cleans up nav_graph.xml (#9829)
4cbb9ae 
* For #9751 - Cleans up homeFragment directions

* For #9751 - Uses global actions for fragments not owned by homeFragment

* For #9751 - Cleans up SearchFragment directions

* For #9751 - Removes settings action from DeleteBrowsingDataFragment

* For #9751 - Removes browser action from SettingsFragment

* For #9751 - Adds ManagePhoneFeature global action

* For #9751 - Clean up unused deletebrowsingfragment actions

* For #9751 - Cleans Up HistoryFragment actions

* For #9751 - Removes Home -> Search action

* For #9751 - Removes the Bookmark -> Browser action

* For #9751 - Cleans up bookmark fragment actions

* For #9751 - Cleans up actions from ShareController

* For #9751 - Removes defaultBrowserFragment to browserFragment action

* For #9751 - Removes about -> browser action

* For #9751 - Adds global action to TrackingProtectionFragment

* For #9751 - Removes exception -> browser action

* For #9751 - Removes login -> browser action

* For #9751 - Fixes LoginFragment directions

* For #9751 - Removes ExternalAppBrowser directions

* for #9751 - Cleans up actions

* For #9751 - Fixes unit tests

* For #9751 - Addresses nits in PR
@boek boek moved this from In progress to Done in Tabs Tray Refactor Apr 16, 2020
@boek boek closed this as completed Apr 16, 2020
@project-bot project-bot bot moved this from In Progress to Sprint 20.4 Done in Fenix Sprint Kanban Apr 16, 2020
@ekager ekager removed the needs:triage Issue needs triage label Apr 17, 2020
@gabrielluong gabrielluong added this to Done in Tabs Tray Apr 24, 2020
@boek boek mentioned this issue May 5, 2020
Merged
@boek boek added the E8 Estimation Point: about 8 days label May 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@boek boek

Labels
E8 Estimation Point: about 8 days Feature:Tabs
Projects
No open projects
Tabs Tray
  
Done
Tabs Tray Refactor
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cleans up nav_graph.xml boek/fenix
3 participants
@boek @ekager @bifleming