[Meta] Pull to refresh issues

[Mugurell]

After enabling "pull to refresh" in #3262 a number of issues were discovered.

Most of the issues relate to the following:

• No differentiation between inner / outer level scrolls.
  We should only show the throbber for top level scrolls.
  GV ticket - https://bugzilla.mozilla.org/show_bug.cgi?id=1627737

• For websites with their own touch handlers but which do not consume the scroll we should allow pull to refresh.
  GV ticket - https://bugzilla.mozilla.org/show_bug.cgi?id=1633322
  Other browsers like Fennec (based on the behavior of the AwesomeBar / overscroll effect) or Chrome correctly support this.
  This needs a deeper investigation and maybe a complete rethink of how pull to refresh / dynamic toolbar works.

• For websites with their own touch handlers we might show a glimpse of the throbbler.
  GV - ticket - https://bugzilla.mozilla.org/show_bug.cgi?id=1631754

• No actual differentiation between zooming / scrolling gestures - [Bug] Pull down to refresh works for any swipes #10241

• "Cancel" on a repost prompt doesn't hide the throbber - [Bug] pull to refresh on form submission is buggy #9799

• Allow users to disable gesture based features - Allow users disabling gesture based features #10240

• Issues with google maps' bottom sheet:

  • the wrong elements scroll - fenix tracking issue | GV ticket
  • rendering issues - GV ticket
  • scroll issues - GV ticket
     

• Support more CSS and Event properties related to pull to refresh - https://bugzilla.mozilla.org/show_bug.cgi?id=1679316

• Avoid unintended refreshes - [Pull To Refresh][Bug] Pull to refresh should only trigger at the start of a pan gesture, not during a gesture which already resulted in scrolling #16577

 
As such we will disable pull to refresh until all of the above issues are resolved.
- [x] #9770

 
With most of the issues fixed this is ready for nightly but should not get into Beta / Release until all issues are fixed.

• Ticket to enable feature in Nightly/Debug - For #16054 - Enable pull to refresh webpage in Nightly and Debug #16060

┆Issue is synchronized with this Jira Task

[abodea]

Hi, below you can find all the related bugs to the Pull to refresh feature.

Website	Bug ID	Reproducible?	Comments
https://bing.com/covid	9724	✔️
Phonearena.com	9720	✔️
twitter	9718	✔️
GitHub	9708	✔️
uBlock Origin settings	9715	✔️
Bugzilla	9715	✔️	Bugzilla bug 1415628

[caugner]

Please also consider disabling pull to refresh after the user has started to fill out a form:

1. Open https://www.caresteouvert.fr/@48.861687,2.333530,17.81/place/n4246099576
2. Select "Report a change"
3. "Select "No"
4. Type in some text
5. (Accidentally) pull down
6. Page refreshes

[abodea]

Hi, @caugner thank you for the notice!
Note that I already verified the issue on the latest build you can find it here #9770 (comment).
The Nightly from the Play Store will update soon and you will be able to see the change too.
I verified the issue following your steps and I couldn't reproduce it as the feature was disabled.

[caugner]

Maybe off-topic, but would be possible to link the feature to a about:config flag?

[staktrace]

See also #9799 - that should be fixed too before re-enabling, and doesn't seem to be covered by the existing issues on this ticket.

[caugner]

The Nightly from the Play Store will update soon and you will be able to see the change too.

My Nightly still pulls to refresh, despite being on the latest Play Store version. This is really frustrating, because I keep losing form input (e.g. on Twitter and in Mattermost).

[cadeyrn]

Play Store updates are paused due to https://bugzilla.mozilla.org/show_bug.cgi?id=1628413.

[liuche]

@Mugurell it looks like the GV bug has been fixed, so it should be in Fenix Nightly. I can't tell if the other issue is a GV bug, but if all the fixes are ready, is this something your team could prioritize in a sprint? It will be important for PWAs to be able to refresh #204 .

[TitanNano]

@liuche PWAs can currently be refreshed via the site control notification.

[0xRustlang]

Sorry for off-topic but please consider making pull to refresh optional.

That is really irritating for some people with accessibility problems like me.

Thank you for all your hard working.

Stay safe.
Regards.

[abodea]

Thank you for this suggestion @3j9fkyahunqoxwqu, note that I will add a feature request regarding this.

[sblatz]

@Mugurell looks like the GV fix is about to land. Once it does, is there anything we need to change on the AC/Fenix side or will we get these benefits for free?

[foscoj]

Very nice feature, love it!
Sometimes there is an unintended refresh when I try pinch to zoom, but it is working great so far!

[Felk]

I am trying to build a website with a canvas to draw on. This requires me to prevent the pull-to-refresh. I took a look at this stackoverflow post and tried the following, simultaneously:

• give the canvas the CSS directive touch-action: none;
• call preventDefault() on the touchmove event
• give the canvas and the body the CSS directive overscroll-behavior: contain;

Firefox nightly still performed the pull-to-refresh gesture. On Chrome adding the touch-action: none; directive to the canvas was sufficient to prevent the pull-to-refresh gesture.

[masayuki-nakano]

* call `preventDefault()` on the touchmove event

Firefox nightly still performed the pull-to-refresh gesture.

As a module owner of DOM Events, I can say this is obviously a bug of Fenix because touchmove must be cancelable event.
https://w3c.github.io/touch-events/#list-of-touchevent-types

[masayuki-nakano]

And Gecko makes touch events cancelable except touchcancel.
https://searchfox.org/mozilla-central/rev/e1d1f043957191616721b9e8bf811c0aab8a203a/widget/TouchEvents.h#166

[mstange]

I've filed #16574, mozilla-mobile/android-components#9043 and #16576 on the webcompat issues enumerated in the previous comments. @Mugurell, could you please add those to the list?
I've also filed #16577 which is not strictly a webcompat issue but should help reduce accidental triggers.

[emilio]

I filed #16574 / #16598 on other compat issues I found.

[Mugurell]

#16577

[mstange]

Also #16661

[steffchep]

I'd be fine with just having a refresh button top-level. rather than inside the menu, tbh.

[Grant-ed]

Does anyone know if there is any progress on this issue? This is the only reason why I am not using the release version, and I can imagine it is for other people as well.

[kelimuttu]

Related discussion on Reddit recently

[kris-kuiper]

Anyone that can tell when this will be available for stable? Been for years now..

[davidacardona]

I'd be fine with just having a refresh button top-level. rather than inside the menu, tbh.

This should be a solution, let you optionally add the refresh button next to the address bar.

[Juraj-Masiar]

Maybe it could be enabled in Beta?
If it needs testing, then adding option to enable it in "Firefox Beta for Testers" sounds like a good start :)
(I've been using it in Nightly for about 2 years and it works like 95%, so pretty good!)

[kelimuttu]

Another related discussion on Reddit about this recently.

[davi-ro]

Maybe it could be enabled in Beta? If it needs testing, then adding option to enable it in "Firefox Beta for Testers" sounds like a good start :) (I've been using it in Nightly for about 2 years and it works like 95%, so pretty good!)

Firefox Beta for Android now supports collections so you can install all kind of plugins made for the main firefox browser and there is a plugin "Pull to Refresh" that works very well for me on android, already tested it for about 2 weeks and no major problems so far. Also thanks to collections, i could test more plugins and some of them work really well in the firefox android browser too.

[lazymonkey2]

@davi-ro
Thanks for the info.
I just tried searching for "pull" to add the extension to my custom collection, but it is not found.
But if I search with google I found this:
https://addons.mozilla.org/en-US/firefox/addon/firefox-pull-to-refresh/
It's just that I'm not able to add it in my custom collection.
How did you managed to add the extension?
Thanks.

[davi-ro]

Find/Add desired plugins into your custom collection, from firefox browser on pc. When using firefox on android you won't see all the addons that firefox has.

[tesmite]

#21536 and #25964 (both are same problem) are caused by this function and it has been a while since it was reported, but there is no follow-up.
This issue has occurred on many sites including GitHub, and we believe it should be resolved as soon as possible.

[csadilek]

Moved to bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1807071

Change performed by the Move to Bugzilla add-on.