Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] Clean up unused FeatureFlags #9782

Closed
sblatz opened this issue Apr 7, 2020 · 3 comments
Closed

[Bug] Clean up unused FeatureFlags #9782

sblatz opened this issue Apr 7, 2020 · 3 comments
Labels
🐞 bug Crashes, Something isn't working, .. eng:health Improve code health good first issue Good for newcomers help wanted Help wanted from a contributor. More complex than good first issue.
Projects
Theme: Eng Health
Milestone
5.2

Comments

@sblatz
Copy link
Contributor

sblatz commented Apr 7, 2020 •
edited by data-sync-user

We currently have quite a few feature flags going unused. We should go through each of these and remove any there are no longer necessary.

┆Issue is synchronized with this Jira Task
@sblatz sblatz added 🐞 bug Crashes, Something isn't working, .. eng:health Improve code health labels Apr 7, 2020
@sblatz
Copy link
Contributor Author

sblatz commented Apr 7, 2020

These three in specific: https://github.com/mozilla-mobile/fenix/blob/master/app/src/main/java/org/mozilla/fenix/FeatureFlags.kt#L21-L31

@github-actions github-actions bot added the needs:triage Issue needs triage label Apr 7, 2020
@ekager ekager mentioned this issue Apr 17, 2020
Merged
4 tasks
@grigoryk
Copy link
Contributor

#10017 removes one of the flags, asFeatureFxAPairingDisabled.

@mcarare mcarare added this to Backlog in Theme: Eng Health via automation May 26, 2020
@mcarare mcarare removed the needs:triage Issue needs triage label May 26, 2020
@NotWoods NotWoods added good first issue Good for newcomers help wanted Help wanted from a contributor. More complex than good first issue. labels May 26, 2020
ekager pushed a commit that referenced this issue Jun 17, 2020
@ekager
For #9782: Clean up unused FeatureFlags
87a65d2 
I've currently found out this ones unused.
webPushIntegration removed because looks like all fatal bugs solved as it said from note.
@NotWoods
Copy link
Contributor

Fixed by 87a65d2

@NotWoods NotWoods added this to the 5.2 milestone Jun 17, 2020
@liuche liuche moved this from Backlog to Sprint Done in Theme: Eng Health Jun 24, 2020
@liuche liuche mentioned this issue Jun 27, 2020
Closed
12 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
🐞 bug Crashes, Something isn't working, .. eng:health Improve code health good first issue Good for newcomers help wanted Help wanted from a contributor. More complex than good first issue.
Projects
No open projects
Theme: Eng Health
  
Sprint Done
Milestone
5.2
Development

No branches or pull requests
4 participants
@grigoryk @NotWoods @sblatz @mcarare