Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug]The cut for scrolling down is made under the Firefox Preview branding logo/text #9808

Closed
sv-sdeiac opened this issue Apr 8, 2020 · 3 comments
Closed

[Bug]The cut for scrolling down is made under the Firefox Preview branding logo/text #9808

sv-sdeiac opened this issue Apr 8, 2020 · 3 comments
Assignees
@sblatz
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:HomeScreen S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist

Comments

@sv-sdeiac
Copy link

sv-sdeiac commented Apr 8, 2020 •
edited by data-sync-user

Steps to reproduce

  1. Open Firefox Preview;
  2. Scroll down till the branding logo/text starts to disappear.

Expected behavior

The cut is made between the branding logo/text and notification bar.

Actual behavior

The cut is made between the branding logo/text and Top sites list.

Device information

Android device:

  • Google Pixel 3 (Android 10);
  • Samsung Galaxy Note 8 (Android 9).

Fenix version: 4/8 #20990609.

  • Old UI
    Screenshot_20200408-171436

  • New UI
    Screenshot_20200408-171403

┆Issue is synchronized with this Jira Task
@sv-sdeiac sv-sdeiac added 🐞 bug Crashes, Something isn't working, .. Feature:HomeScreen S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist labels Apr 8, 2020
@sv-sdeiac sv-sdeiac mentioned this issue Apr 8, 2020
Closed
@github-actions github-actions bot added the needs:triage Issue needs triage label Apr 8, 2020
@sblatz
Copy link
Contributor

sblatz commented Apr 13, 2020

@AmyYLee what's the correct behavior here? This is a quick fix :)

@sblatz sblatz self-assigned this Apr 13, 2020
@AmyYLee
Copy link
Collaborator

AmyYLee commented Apr 13, 2020 •
edited

@AmyYLee what's the correct behavior here? This is a quick fix :)

Hi @sblatz

Can you shorten the logo fade out so it disappears when top sites overlaps it? The goal is to no look like the logo is getting sliced when top sites move up. Thanks!

@sblatz sblatz removed the needs:triage Issue needs triage label Apr 14, 2020
sblatz added a commit to sblatz/fenix that referenced this issue Apr 14, 2020
@sblatz
For mozilla-mobile#9808: Fix scrolling cutoff on homescreen
6baed66
sblatz added a commit to sblatz/fenix that referenced this issue Apr 17, 2020
@sblatz
For mozilla-mobile#9808: Fix scrolling cutoff on homescreen
2b38417
ekager pushed a commit that referenced this issue Apr 18, 2020
@sblatz @ekager
For #9808: Fix scrolling cutoff on homescreen
89cfa3e
@ekager ekager added the eng:qa:needed QA Needed label Apr 18, 2020
@AndiAJ
Copy link
Collaborator

AndiAJ commented Apr 22, 2020

Hi, verified as fixed on the latest Nightly Build #21130610 from 4/22 using the following devices:
• Google Pixel 3a (Android 10)
• Huawei Mate 20 Lite (Android 9)
• OnePlus A3 (Android 6.0.1)

► Video
20200422-092805

@AndiAJ AndiAJ closed this as completed Apr 22, 2020
@AndiAJ AndiAJ added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Apr 22, 2020
@liuche liuche mentioned this issue Apr 28, 2020
Closed
32 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sblatz sblatz

Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:HomeScreen S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@sblatz @AmyYLee @ekager @sv-sdeiac @AndiAJ