Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] "Open in Firefox Preview" from Custom Tab opens home page not tab #9815

Closed
ekager opened this issue Apr 9, 2020 · 8 comments
Closed

[Bug] "Open in Firefox Preview" from Custom Tab opens home page not tab #9815

ekager opened this issue Apr 9, 2020 · 8 comments
Assignees
@pocmo @sblatz
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified eng:ready Ready for engineering Feature:CustomTabs P1 Current sprint S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist
Projects
Fenix Sprint Kanban Fenix:AC Bugs A-C: Android Components Sprint Planning

Comments

@ekager
Copy link
Contributor

ekager commented Apr 9, 2020 •
edited by data-sync-user
Loading

Steps to reproduce

  1. Open any website in custom tab
  2. Open menu and click "Open in Firefox Preview"

Expected behavior

Webpage opens in app

Actual behavior

App opens to home screen

Device information

  • Android device: ?
  • Fenix version: ?

┆Issue is synchronized with this Jira Task
@ekager ekager added 🐞 bug Crashes, Something isn't working, .. Feature:CustomTabs labels Apr 9, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Apr 9, 2020
@ekager ekager added eng:ready Ready for engineering help wanted Help wanted from a contributor. More complex than good first issue. labels Apr 9, 2020
@mcarare
Copy link
Contributor

mcarare commented Apr 9, 2020

For me the tab is opened, but without navigating to it.

@ekager
Copy link
Contributor Author

ekager commented Apr 9, 2020

Right, it should navigate to it.

@ekager ekager self-assigned this Apr 10, 2020
ekager added a commit to ekager/fenix that referenced this issue Apr 10, 2020
@ekager
For mozilla-mobile#9815 - Open in Fenix custom tab menu should open t…
f04c970 
…o tab
@ekager
Copy link
Contributor Author

ekager commented Apr 10, 2020

CC @pocmo I'm not positive, just started digging around, but could this be a regression from #8823 ? It was the only recent change to intent processing I found (and nothing with the OpenInFenixIntent was changed).

Looks like it's being processed as an OTHER intent (with a null processor). Should we be adding another custom extra here for HomeActivity to process and open to the browser correctly?

@ekager ekager removed their assignment Apr 16, 2020
@ekager ekager added S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist and removed needs:triage Issue needs triage labels Apr 16, 2020
@ekager ekager added this to Prioritized Bug Backlog in Fenix Sprint Kanban Apr 16, 2020
@ekager ekager mentioned this issue Apr 20, 2020
Closed
@apoorv9990
Copy link
Contributor

Hi, I would like to work on this. I tried to repro it but not sure how to open a custom tab on the Firefox app 😅. Any pointers would be helpful.

@androidacy-user
Copy link

Hi, I would like to work on this. I tried to repro it but not sure how to open a custom tab on the Firefox app 😅. Any pointers would be helpful.

Open a link in an app that uses custom tabs, eg Telegram

@ekager ekager removed the help wanted Help wanted from a contributor. More complex than good first issue. label Apr 23, 2020
cnevinc added a commit to cnevinc/fenix that referenced this issue Apr 24, 2020
@cnevinc
For mozilla-mobile#9815: "Open in Firefox Preview" from Custom Tab sh…
54fed52 
…ould open tab, not home page.
cnevinc added a commit to cnevinc/fenix that referenced this issue Apr 24, 2020
@cnevinc
For mozilla-mobile#9815: "Open in Firefox Preview" from Custom Tab sh…
75fc7a7 
…ould open tab, not home page.

Since last commit (a477f14) didn't call `match()`, TabIntent won't have the chance to intercept the intent from Custom Tab "Open in Firefox Preview" menu item.

Before we fix the combination of `match()` and `process()` in A-C, we need to call it this way here: if matched, then process it.
cnevinc added a commit to cnevinc/fenix that referenced this issue Apr 24, 2020
@cnevinc
For mozilla-mobile#9815: "Open in Firefox Preview" from Custom Tab sh…
383a89d 
…ould open tab, not home page.

Since last commit (a477f14) didn't call `match()`, TabIntentProcessor won't have the chance to intercept the intent from Custom Tab "Open in Firefox Preview" menu item.

Before we fix the combination of `match()` and `process()` in A-C, we need to call it this way here: if matched, then process it.
cnevinc added a commit to cnevinc/fenix that referenced this issue Apr 24, 2020
@cnevinc
For mozilla-mobile#9815: "Open in Firefox Preview" from Custom Tab sh…
1fc5df5 
…ould open tab, not home page.

Since last commit (a477f14) didn't call `match()`, TabIntentProcessor won't have the chance to intercept the intent from Custom Tab "Open in Firefox Preview" menu item.

Before we fix the combination of `match()` and `process()` in A-C, we need to call it this way here: if matched, then process it.
cnevinc added a commit to cnevinc/fenix that referenced this issue Apr 27, 2020
@cnevinc
For mozilla-mobile#9815: "Open in Firefox Preview" from Custom Tab sh…
c38cfae 
…ould open tab, not home page.
@vesta0 vesta0 added P1 Current sprint Skittle labels Apr 28, 2020
@vesta0 vesta0 moved this from Prioritized Bug Backlog to Prioritized Backlog in Fenix Sprint Kanban May 7, 2020
@vesta0 vesta0 removed the Skittle label May 7, 2020
@liuche
Copy link
Contributor

liuche commented May 11, 2020

We'll add it to our sprint, and the eng work here is to shepherd it along and make sure it's making progress.

@liuche liuche added this to Backlog in Fenix:AC Bugs via automation May 11, 2020
@liuche liuche moved this from Backlog to Top 10 in Fenix:AC Bugs May 11, 2020
@liuche liuche moved this from Prioritized Backlog to Sprint Backlog in Fenix Sprint Kanban May 11, 2020
@sblatz sblatz self-assigned this May 15, 2020
@pocmo pocmo self-assigned this May 26, 2020
@pocmo pocmo added this to 🏃‍♀️ In Progress in A-C: Android Components Sprint Planning May 26, 2020
pocmo added a commit to pocmo/fenix that referenced this issue May 26, 2020
@pocmo
Issue mozilla-mobile#9815: Allow Intents to set HomeActivity.OPEN_TO_…
68d1087 
…BROWSER.
@pocmo pocmo mentioned this issue May 26, 2020
Merged
@Amejia481 Amejia481 moved this from Top 10 to In Progress in Fenix:AC Bugs May 26, 2020
pocmo added a commit to pocmo/fenix that referenced this issue May 27, 2020
@pocmo
Issue mozilla-mobile#9815: Allow Intents to set HomeActivity.OPEN_TO_…
aebc5e5 
…BROWSER.
pocmo added a commit that referenced this issue May 27, 2020
@pocmo
Issue #9815: Allow Intents to set HomeActivity.OPEN_TO_BROWSER.
21bd379
@pocmo pocmo added the eng:qa:needed QA Needed label May 27, 2020
@pocmo
Copy link
Contributor

pocmo commented May 27, 2020

Just landed a patch for this and it should get into the next Nightly build of Fenix.

@sblatz sblatz moved this from Sprint to Ready for QA in Fenix Sprint Kanban May 28, 2020
@lobontiumira
Copy link

Verified as fixed on the latest Nightly build from 5/29 with:

  • OnePlus 5T (Android 9),
  • Google Pixel (Android 10), and
  • Sony Xperia Z5 Premium (Android 7.1.1).

A-C: Android Components Sprint Planning automation moved this from 🏃‍♀️ In Progress to 🏁 Done May 29, 2020
Fenix:AC Bugs automation moved this from In Progress to Done May 29, 2020
@lobontiumira lobontiumira added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels May 29, 2020
@project-bot project-bot bot moved this from Ready for QA to Sprint in Fenix Sprint Kanban May 29, 2020
@liuche liuche moved this from Sprint to Sprint 20.10 Done in Fenix Sprint Kanban May 29, 2020
@liuche liuche mentioned this issue Jun 10, 2020
Closed
29 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pocmo pocmo

@sblatz sblatz

Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified eng:ready Ready for engineering Feature:CustomTabs P1 Current sprint S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist
Projects
Fenix Sprint Kanban
  
Sprint 20.10 Done
A-C: Android Components Sprint Planning
  
🏁 Done
Fenix:AC Bugs
  
Done
Milestone
No milestone
Development

No branches or pull requests
9 participants
@pocmo @liuche @sblatz @apoorv9990 @ekager @lobontiumira @vesta0 @androidacy-user @mcarare