Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Create UI Style for Text Buttons #9857

Closed
5 of 6 tasks
Tracked by #10991
sblatz opened this issue Apr 10, 2020 · 2 comments
Closed
5 of 6 tasks
Tracked by #10991

Create UI Style for Text Buttons #9857

sblatz opened this issue Apr 10, 2020 · 2 comments
Labels
style guide Issues related to the UX style guide wontfix
Projects
Design Consistency

Comments

@sblatz
Copy link
Contributor

sblatz commented Apr 10, 2020 •
edited by data-sync-user

Acceptance Criteria (how do I know when I’m done?)

  • There is a style engineers can import for buttons
  • There is a living (and public) style guide that both engineers & UX can point to when discussing designs
  • Every text button in the app will adhere to a common pattern so we have consistency

Stretch goal: This style lives in a library we can import separately from Fenix (like in AC)

General Process

  • UX identifies components we’re using
  • Engineering finds usages
  • UX & Engineering collaborate on “rules”
  • Engineer implements the style
  • UX & Engineering meet to do “final approval” of the component
    1. Walk through all affected screens
    2. Chat about remaining questions
  • UX & Engineering place component in the library

┆Issue is synchronized with this Jira Task
@sblatz sblatz added the style guide Issues related to the UX style guide label Apr 10, 2020
@sblatz sblatz self-assigned this Apr 10, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Apr 10, 2020
@sblatz sblatz removed the needs:triage Issue needs triage label Apr 10, 2020
sblatz added a commit to sblatz/fenix that referenced this issue Apr 10, 2020
@sblatz
For mozilla-mobile#9857: Create button style
cc72ad2
sblatz added a commit to sblatz/fenix that referenced this issue Apr 10, 2020
@sblatz
For mozilla-mobile#9857: Creates text button style
a2dded0
@sblatz sblatz added this to In progress in Design Consistency Apr 13, 2020
sblatz added a commit to sblatz/fenix that referenced this issue Apr 13, 2020
@sblatz
For mozilla-mobile#9857: Creates text button style
bce90e3
sblatz added a commit to sblatz/fenix that referenced this issue Apr 15, 2020
@sblatz
For mozilla-mobile#9857: Creates text button style
168ba95
sblatz added a commit that referenced this issue Apr 15, 2020
@sblatz
For #9857: Create button style (#9858)
8185ba7 
* For #9857: Creates text button style

* Adds lint check

* Fixes onboarding cards
@liuche liuche mentioned this issue Apr 28, 2020
Closed
32 tasks
sblatz added a commit to sblatz/fenix that referenced this issue May 7, 2020
@sblatz
For mozilla-mobile#9857: Updates onboarding button styles
78dc0d9
ekager pushed a commit that referenced this issue May 8, 2020
@sblatz @ekager
For #9857: Updates onboarding button styles
5f11c5e
sblatz added a commit that referenced this issue May 11, 2020
@sblatz
For #9857 & #8643: Updates onboarding button styles and sizes (#10527)
0f10ce8 
* For #9857: Updates onboarding button styles

* For #8643: Updates colors of onboarding accents
@liuche liuche mentioned this issue May 19, 2020
Closed
32 tasks
@sblatz sblatz mentioned this issue May 28, 2020
Closed
2 tasks
@sblatz
Copy link
Contributor Author

sblatz commented May 28, 2020

This has been implemented in Android Components with the ui-widgets project. It also has a temporary style guide representation from UX in this slide deck. The last bit of work left for this one is to put it in a long-standing open source style guide document!

@sblatz sblatz removed their assignment Sep 25, 2020
@stale
Copy link

stale bot commented Mar 25, 2021

See: #17373 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Mar 25, 2021
@stale stale bot closed this as completed Apr 1, 2021
@gabrielluong gabrielluong mentioned this issue Apr 2, 2021
Closed
@eliserichards eliserichards mentioned this issue Apr 22, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
style guide Issues related to the UX style guide wontfix
Projects
No open projects
Design Consistency
  
In progress
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sblatz