Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] PB-The effect of black screen when recording is cancelled by returning from "Saved Logins" #9887

Closed
Diana-Rus opened this issue Apr 13, 2020 · 1 comment
Closed

[Bug] PB-The effect of black screen when recording is cancelled by returning from "Saved Logins" #9887

Diana-Rus opened this issue Apr 13, 2020 · 1 comment
Assignees
@ekager
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:PrivateBrowsing S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist

Comments

@Diana-Rus
Copy link

Diana-Rus commented Apr 13, 2020 •
edited by data-sync-user

Prerequisites

  • Have a screen recorder turned on.
  • Have the app opened in private browsing mode.

Steps to reproduce

  1. Go to "Menu"/"Settings"/"Private browsing".
  2. Disable "Allow screenshots in private browsing" by tapping on the toggle.
  3. Go back to "Settings".
  4. Go to "Logins and Password".
  5. Go to "Saved logins".
  6. Go to the previous screen by tapping the back arrow from app or from device.

Expected behavior

The "Allow screenshots in private browsing" is disabled. The screen recorder cannot capture the apps interface.

Actual behavior

The "Allow screenshots in private browsing" is enabled. The app's interface is captured by the screen recorder.

Device information

  • Android device: Google Pixel 3 XL (Android 9), Samsung Galaxy S9 (Android 8), Sony Xperia Z5 (Android 7)
  • Fenix version: Nightly Debug version 39.0.20200412130044, d433836f0 GV: 77.0a1-20200410095419 AS: 0.55.0

Samsung Galaxy S9 - Allow screenshots in private browsing - Disabled
20200413-191341

┆Issue is synchronized with this Jira Task
@Diana-Rus Diana-Rus added the 🐞 bug Crashes, Something isn't working, .. label Apr 13, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Apr 13, 2020
@Diana-Rus Diana-Rus added S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist Feature:PrivateBrowsing and removed needs:triage Issue needs triage labels Apr 13, 2020
@ekager ekager self-assigned this Apr 14, 2020
ekager added a commit to ekager/fenix that referenced this issue Apr 14, 2020
@ekager
For mozilla-mobile#9887 - Respect screenshot setting when resetting w…
e3d1af3 
…indow flags in logins
ekager added a commit to ekager/fenix that referenced this issue Apr 14, 2020
@ekager
For mozilla-mobile#9887 - Respect screenshot setting when resetting w…
7d17fba 
…indow flags in logins
ekager added a commit that referenced this issue Apr 15, 2020
@ekager
For #9887 - Respect screenshot setting when resetting window flags in…
aef827e 
… logins
@ekager ekager added the eng:qa:needed QA Needed label Apr 15, 2020
@ekager ekager added this to Ready for QA in Fenix Sprint Kanban Apr 15, 2020
@abodea
Copy link
Member

abodea commented Apr 16, 2020

Verified as fixed on the latest Nightly 4/16 with Google Pixel 4 XL (10).
Note that everything is displayed as expected and the recording is dark.
I also added this issue #9987 that is an edge case.

@abodea abodea closed this as completed Apr 16, 2020
@project-bot project-bot bot moved this from Ready for QA to Sprint 20.4 Done in Fenix Sprint Kanban Apr 16, 2020
@abodea abodea added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Apr 16, 2020
@liuche liuche mentioned this issue Apr 28, 2020
Closed
32 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ekager ekager

Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:PrivateBrowsing S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ekager @abodea @Diana-Rus