Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] wrong position of fullscreen snackbar #9890

Closed
cadeyrn opened this issue Apr 13, 2020 · 6 comments
Closed

[Bug] wrong position of fullscreen snackbar #9890

cadeyrn opened this issue Apr 13, 2020 · 6 comments
Labels
🐞 bug Crashes, Something isn't working, .. Feature:Media P2 Upcoming release S3 Blocks non-critical functionality and a work around exists wontfix
Projects
A-C: Media

Comments

@cadeyrn
Copy link
Contributor

cadeyrn commented Apr 13, 2020 •
edited by data-sync-user

Steps to reproduce

  1. open a video in fullscreen mode

Expected behavior

The snackbar appears on the bottom of the screen

Actual behavior

The toolbar is displayed on the wrong position.

Screenshot_20200413-185019

Device information

  • Android device: OnePlus 7T Pro McLaren Edition / Oxygen OS 10.0.8 (Android 10)
  • Fenix version: master branch revision 52857b0

┆Issue is synchronized with this Jira Task
@cadeyrn cadeyrn added the 🐞 bug Crashes, Something isn't working, .. label Apr 13, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Apr 13, 2020
@ekager ekager added Feature:Media P2 Upcoming release and removed needs:triage Issue needs triage labels Apr 13, 2020
@ekager ekager added this to Fenix Media Bug Bucket in A-C: Media Apr 13, 2020
@ekager ekager moved this from Fenix Media Bug Bucket to Fenix Eng-Ready Bug Backlog in A-C: Media Apr 13, 2020
@ekager ekager self-assigned this Apr 13, 2020
ekager added a commit to ekager/fenix that referenced this issue Apr 13, 2020
@ekager
For mozilla-mobile#9890 - Do not display full screen snackbar with to…
0173d8b 
…olbar padding
ekager added a commit that referenced this issue Apr 13, 2020
@ekager
For #9890 - Do not display full screen snackbar with toolbar padding
b8fba63
@ekager ekager added the eng:qa:needed QA Needed label Apr 13, 2020
@liuche liuche mentioned this issue Apr 13, 2020
Closed
32 tasks
liuche pushed a commit that referenced this issue Apr 13, 2020
@ekager @liuche
For #9890 - Do not display full screen snackbar with toolbar padding
b87a9dd
@ekager ekager moved this from Fenix Eng-Ready Bug Backlog to In Progress in A-C: Media Apr 14, 2020
@AndiAJ
Copy link
Collaborator

AndiAJ commented Apr 14, 2020 •
edited

Hi, verified as fixed on Fenix beta 4.3.0-beta.1 (Build #21050021) using the following devices:
• Google Pixel 3a (Android 10)
• Huawei Mate 20 Lite (Android 9)
• OnePlus A3 (Android 6.0.1)

► Video
20200414-113014

@AndiAJ AndiAJ closed this as completed Apr 14, 2020
A-C: Media automation moved this from In Progress to Done Apr 14, 2020
@AndiAJ AndiAJ added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Apr 14, 2020
@cadeyrn
Copy link
Contributor Author

cadeyrn commented Apr 16, 2020

@ekager: It looks not fixed on OnePlus 7T Pro McLaren Edition with Oxygen OS 10.0.8 (Android 10). This is a screenshot taken from a build from master branch revision 335642d:

Screenshot_20200416-210114

It looks the same as in the original report but is a current screenshot.

@ekager
Copy link
Contributor

ekager commented Apr 17, 2020

cc @sblatz this doesn't happen when the toolbar is in the top position. Any ideas here or PRs in flight you think will help?

@ekager ekager reopened this Apr 17, 2020
@ekager ekager removed the eng:qa:verified QA Verified label Apr 23, 2020
@liuche liuche mentioned this issue Apr 28, 2020
Closed
32 tasks
@liuche liuche moved this from Done to Fenix Eng-Ready Bug Backlog in A-C: Media May 26, 2020
@ekager ekager removed their assignment May 29, 2020
@ekager
Copy link
Contributor

ekager commented May 29, 2020

@cadeyrn are you still noticing this? Was trying to figure out if it's device dependent or has been resolved by some other work but haven't been able to reproduce locally

@cadeyrn
Copy link
Contributor Author

cadeyrn commented May 30, 2020

Yes, it's still an issue.

@rocketsroger rocketsroger added the S3 Blocks non-critical functionality and a work around exists label Dec 7, 2020
@stale
Copy link

stale bot commented Jun 5, 2021

See: #17373 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jun 5, 2021
@stale stale bot closed this as completed Jun 12, 2021
A-C: Media automation moved this from Fenix Eng-Ready Bug Backlog to Done Jun 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
🐞 bug Crashes, Something isn't working, .. Feature:Media P2 Upcoming release S3 Blocks non-critical functionality and a work around exists wontfix
Projects
No open projects
A-C: Media
  
Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@cadeyrn @rocketsroger @ekager @AndiAJ