Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] Snackbar- "Bookmark saved" and "Edit" action are not aligned correctly #9907

Closed
Diana-Rus opened this issue Apr 14, 2020 · 3 comments
Closed

[Bug] Snackbar- "Bookmark saved" and "Edit" action are not aligned correctly #9907

Diana-Rus opened this issue Apr 14, 2020 · 3 comments
Assignees
@mcarare
Labels
🐞 bug Crashes, Something isn't working, .. eng:ready Ready for engineering Feature:Snackbar 🌐 L10N Localization, translation, strings, .. S3 Blocks non-critical functionality and a work around exists
Projects
Hershey's 🍫

Comments

@Diana-Rus
Copy link

Diana-Rus commented Apr 14, 2020 •
edited by data-sync-user

Prerequisites:

  • Change the language of the device to German

Steps to reproduce

  1. Open Fenix and make a search after a site.
  2. Bookmark the site.
  3. Check the bookmark snackbar.

Expected behavior

The "Bookmark saved" and "Edit" button are correctly aligned.

Actual behavior

The "Bookmark saved" and "Edit" button are not correctly aligned.

Device information

  • Android device: Google Pixel 3 XL (Android 9)
  • Fenix version: Beta 4.3.0-beta.1
    Note:
  • WIth Samsung Galaxy S9 (Android 8) and Sony Xperia Z5 (Android 7) the issue does not reproduce.
  • I only reproduced with German language.

Screen:
Screenshot_20200414-111604edit

┆Issue is synchronized with this Jira Task
@Diana-Rus Diana-Rus added 🐞 bug Crashes, Something isn't working, .. S3 Blocks non-critical functionality and a work around exists 🌐 L10N Localization, translation, strings, .. labels Apr 14, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Apr 14, 2020
@Diana-Rus Diana-Rus added Feature:Snackbar and removed needs:triage Issue needs triage labels Apr 14, 2020
@ekager ekager added the eng:ready Ready for engineering label Apr 14, 2020
@mcarare mcarare self-assigned this Jun 11, 2020
@mcarare mcarare added this to In Progress in Hershey's 🍫 Jun 11, 2020
@mcarare
Copy link
Contributor

mcarare commented Jun 11, 2020

Can QA please retest this? (maybe for a couple other languages as well). Changes have been there since this was reported. TY!

@mcarare mcarare added the eng:qa:needed QA Needed label Jun 11, 2020
@mcarare mcarare moved this from In Progress to QA Review in Hershey's 🍫 Jun 12, 2020
@sflorean
Copy link
Contributor

Tested on Nightly 6/12 with Samsung Galaxy Note10 (Android 10), Nokia 6 (Android 7.1.1), Google Pixel 3 (Android 11-beta) with different languages, including the one from the description and couldn't see any issues landscape/portrait.

@sflorean sflorean removed the eng:qa:needed QA Needed label Jun 12, 2020
@mcarare
Copy link
Contributor

mcarare commented Jun 15, 2020

Closing, as per #9907 (comment).

@mcarare mcarare closed this as completed Jun 15, 2020
@mcarare mcarare moved this from QA Review to Done in Hershey's 🍫 Jun 19, 2020
grigoryk pushed a commit to grigoryk/fenix that referenced this issue Mar 16, 2021
Closes mozilla-mobile#9907: Enable Nimbus on Beta channel
f6f74cd
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mcarare mcarare

Labels
🐞 bug Crashes, Something isn't working, .. eng:ready Ready for engineering Feature:Snackbar 🌐 L10N Localization, translation, strings, .. S3 Blocks non-critical functionality and a work around exists
Projects
No open projects
Hershey's 🍫
  
Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ekager @mcarare @Diana-Rus @sflorean