Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug]Can't shrink the collections #9914

Closed
AndiAJ opened this issue Apr 14, 2020 · 3 comments
Closed

[Bug]Can't shrink the collections #9914

AndiAJ opened this issue Apr 14, 2020 · 3 comments
Assignees
@mcarare
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Collections S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist

Comments

@AndiAJ
Copy link
Collaborator

AndiAJ commented Apr 14, 2020 •
edited by data-sync-user

Prerequisites

Have a collection created.

Steps to reproduce

  1. Tap on the right side of the previously created collection
  2. Tap on the share button
  3. Tap somewhere next to the share button
  4. Tap on the space between the Collections name and share button
  5. Tap on the collections name or on the expand/shrink sign

Expected behavior

At Step 3 the share button shouldn't be pressed.
At Step 5 the collection should shrink

Actual behavior

At Step 3 performing a tap next to the share button opens the share screen
At step 5 can't shrink the collection

Device information

  • Android device: nePlus A3 (Android 6.0.1)
  • Fenix version:
    • Fenix beta 4.3.0-beta.1 (Build #21050021)
    • Debug build from Master 4/14

Notes

► Video
20200414-151621

❗ Seems to be happening when performing actions on the hidden collections buttons.
Similar with #9913

┆Issue is synchronized with this Jira Task
@AndiAJ AndiAJ added 🐞 bug Crashes, Something isn't working, .. Feature:Collections S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist labels Apr 14, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Apr 14, 2020
@mcarare
Copy link
Contributor

mcarare commented Apr 23, 2020 •
edited

Should be fixed when #10179 lands.

@mcarare mcarare self-assigned this Apr 23, 2020
mcarare added a commit to mcarare/fenix that referenced this issue Apr 24, 2020
@mcarare
For mozilla-mobile#9913, For mozilla-mobile#9914: Remove button when …
5e08392 
…disabling it.

Setting visibility to GONE allows clicks to parent view in that space.
mcarare added a commit that referenced this issue Apr 24, 2020
@mcarare
For #9913, For #9914: Remove button when disabling it.
2edd4b3 
Setting visibility to GONE allows clicks to parent view in that space.
@mcarare mcarare added the eng:qa:needed QA Needed label Apr 24, 2020
@Diana-Rus
Copy link

Diana-Rus commented Apr 27, 2020 •
edited

Hi, issue is reproducible on Firefox Preview Nightly 4/27 with Samsung Galaxy S9 (Android 8) - please check GIF.
Issue is fixed on Firefox Preview Nightly 4/27 with Sony Xperia Z5 (Android 7) and Google Pixel 3 XL (Android 9)

Sony Xperia Z5 - GIF - ✔️
20200427-111308

Pixel 3 XL - GIF - ✔️
20200427-112625

Samsung Galaxy S9 - GIF - ❌
20200427-115602

@Diana-Rus Diana-Rus removed the eng:qa:needed QA Needed label Apr 27, 2020
@Diana-Rus Diana-Rus mentioned this issue Apr 27, 2020
Closed
mcarare added a commit to mcarare/fenix that referenced this issue Apr 27, 2020
@mcarare
For mozilla-mobile#9913, For mozilla-mobile#9914: Remove touch delega…
6997b20 
…te when buttons are disabled.
mcarare added a commit to mcarare/fenix that referenced this issue Apr 27, 2020
@mcarare
For mozilla-mobile#9913, For mozilla-mobile#9914: Remove touch delega…
4b3744a 
…te when button is disabled.
ekager pushed a commit that referenced this issue Apr 27, 2020
@mcarare @ekager
For #9913, For #9914: Remove touch delegate when button is disabled.
1aa473b
@ekager ekager added the eng:qa:needed QA Needed label Apr 27, 2020
@abodea
Copy link
Member

abodea commented Apr 28, 2020

Verified as fixed on the latest Nightly 4/28 with Google Pixel 4 XL (10), Samsung Galaxy S9 (9).

@abodea abodea closed this as completed Apr 28, 2020
@abodea abodea added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed needs:triage Issue needs triage labels Apr 28, 2020
@liuche liuche mentioned this issue Apr 28, 2020
Closed
32 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mcarare mcarare

Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Collections S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@ekager @abodea @mcarare @Diana-Rus @AndiAJ