Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

for #9783: bring app in focus with sendSingleTapToScreen #10136

Merged
merged 1 commit into from Apr 28, 2020

Conversation

sv-ohorvath
Copy link
Contributor

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@sv-ohorvath sv-ohorvath marked this pull request as draft April 23, 2020 08:53
@sv-ohorvath
Copy link
Contributor Author

sv-ohorvath commented Apr 23, 2020

@rpappalax Aaron reviewed this method to avoid an emulator specific error where the app is not in focus here: #9767 (comment)
We just need your second opinion if I should keep this or try something else. Suggestions are welcome.

@sv-ohorvath sv-ohorvath self-assigned this Apr 23, 2020
@sv-ohorvath sv-ohorvath added the eng:automation Build automation, Continuous integration, .. label Apr 23, 2020
@sv-ohorvath sv-ohorvath force-pushed the fix9783-closePrivateTabsNotificationTest branch from 6d45fbc to 7c97e6a Compare April 24, 2020 08:42
@sv-ohorvath sv-ohorvath reopened this Apr 24, 2020
@sv-ohorvath sv-ohorvath force-pushed the fix9783-closePrivateTabsNotificationTest branch from 7c97e6a to 854bbe7 Compare April 28, 2020 13:52
@sv-ohorvath sv-ohorvath marked this pull request as ready for review April 28, 2020 13:53
@sv-ohorvath sv-ohorvath changed the title for #9783:bring app in focus with sendSingleTapToScreen for #9783: bring app in focus with sendSingleTapToScreen Apr 28, 2020
@AaronMT AaronMT merged commit 2c18c25 into master Apr 28, 2020
@AaronMT AaronMT removed the request for review from rpappalax April 28, 2020 14:47
@sv-ohorvath sv-ohorvath deleted the fix9783-closePrivateTabsNotificationTest branch April 28, 2020 14:49
@liuche liuche mentioned this pull request Apr 28, 2020
32 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
eng:automation Build automation, Continuous integration, ..
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants