Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #10162: Set switch back to prev state when failed to enable/disable addon #10164

Merged
merged 1 commit into from
Apr 24, 2020

Conversation

psymoon
Copy link
Contributor

@psymoon psymoon commented Apr 23, 2020

Debugged and verified that setting switch.isChecked inside switch.setOnCheckedChangeListener doesn't fire up the callback again.

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@codecov-io
Copy link

codecov-io commented Apr 23, 2020

Codecov Report

Merging #10164 into master will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #10164      +/-   ##
============================================
- Coverage     18.94%   18.93%   -0.01%     
  Complexity      532      532              
============================================
  Files           343      343              
  Lines         13974    13977       +3     
  Branches       1871     1871              
============================================
  Hits           2647     2647              
- Misses        11086    11089       +3     
  Partials        241      241              
Impacted Files Coverage Δ Complexity Δ
...illa/fenix/addons/InstalledAddonDetailsFragment.kt 0.00% <0.00%> (ø) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e51e1c8...6821764. Read the comment docs.

Copy link
Contributor

@Amejia481 Amejia481 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@psymoon psymoon merged commit f1559ed into mozilla-mobile:master Apr 24, 2020
@liuche liuche mentioned this pull request Apr 28, 2020
32 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants