Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

No Issue: Update Readme with steps to fix prepush hooks error #10638

Conversation

Vishwa-Mozilla
Copy link
Contributor

Updating Readme to include fix to error "Could not initialize class org.codehaus.groovy.runtime.InvokerHelper" which came up while running prepush hooks

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

Updating Readme to include fix to error "Could not initialize class org.codehaus.groovy.runtime.InvokerHelper" which came up while running prepush hooks
@Vishwa-Mozilla Vishwa-Mozilla requested a review from a team May 13, 2020 22:49
README.md Outdated Show resolved Hide resolved
@codecov-io
Copy link

Codecov Report

Merging #10638 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #10638      +/-   ##
============================================
- Coverage     19.20%   19.19%   -0.01%     
  Complexity      599      599              
============================================
  Files           360      360              
  Lines         14801    14801              
  Branches       2001     2001              
============================================
- Hits           2842     2841       -1     
- Misses        11699    11700       +1     
  Partials        260      260              
Impacted Files Coverage Δ Complexity Δ
...ix/home/sessioncontrol/SessionControlController.kt 71.17% <0.00%> (-0.91%) 0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7993f10...125d691. Read the comment docs.

Copy link
Contributor

@kglazko kglazko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also change the name of the commit and the PR title to something that makes it more clear that you're changing the readme (i.e. No Issue: Update README with steps to fix prepush hooks error). We like to use No Issue to indicate that there's no issue filed for this specific PR.

README.md Outdated Show resolved Hide resolved
@Vishwa-Mozilla Vishwa-Mozilla changed the title Steps to fix prepush hooks error No Issue: Steps to fix prepush hooks error May 14, 2020
@Vishwa-Mozilla Vishwa-Mozilla changed the title No Issue: Steps to fix prepush hooks error No Issue: Update Readme with steps to fix prepush hooks error May 14, 2020
Copy link
Contributor

@kglazko kglazko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the changes! Looks great.

@Vishwa-Mozilla Vishwa-Mozilla merged commit 94fb5a7 into mozilla-mobile:master May 14, 2020
@liuche liuche mentioned this pull request May 19, 2020
32 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants