Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Closes #10782: Update crash reporting doc with what information breadcrumbs are recording #10787

Merged
merged 1 commit into from
May 20, 2020

Conversation

rocketsroger
Copy link
Contributor

@rocketsroger rocketsroger commented May 19, 2020

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@rocketsroger rocketsroger requested a review from liuche May 19, 2020 20:47
@codecov-commenter
Copy link

codecov-commenter commented May 19, 2020

Codecov Report

Merging #10787 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #10787   +/-   ##
=========================================
  Coverage     19.18%   19.18%           
  Complexity      600      600           
=========================================
  Files           360      360           
  Lines         14821    14821           
  Branches       2011     2011           
=========================================
  Hits           2843     2843           
  Misses        11718    11718           
  Partials        260      260           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0e4056...db9087b. Read the comment docs.

Copy link
Contributor

@liuche liuche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also linking to data review bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1635932

Couldn't find where the breadcrumb code was originally added, but this is now in BreadcrumbRecorder.kt


### Events

In [HomeActivity](https://github.com/mozilla-mobile/fenix/blob/master/app/src/main/java/org/mozilla/fenix/HomeActivity.kt) when `onDestinationChanged` occurs, the destination fragment's name and its custom tab value is added to the breadcrumbs.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"and whether it is a custom tab" (to make it clear it's a boolean)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I'll fix.

@liuche
Copy link
Contributor

liuche commented May 20, 2020

(in the future, you don't need to file the data review in bugzilla, but can just include it in the PR, like #10785 - that will keep all this documentation/code changes together so it's easy to find in the future)

@rocketsroger rocketsroger merged commit 15e2621 into mozilla-mobile:master May 20, 2020
@rocketsroger rocketsroger deleted the FB_10782 branch May 20, 2020 14:44
@liuche liuche mentioned this pull request Jun 10, 2020
29 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants