Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Closes #10802: Add crash reporting opt in mechanism in doc #10804

Merged
merged 1 commit into from May 21, 2020
Merged

Closes #10802: Add crash reporting opt in mechanism in doc #10804

merged 1 commit into from May 21, 2020

Conversation

rocketsroger
Copy link
Contributor

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@rocketsroger rocketsroger requested a review from liuche May 20, 2020 16:28
@codecov-commenter
Copy link

codecov-commenter commented May 20, 2020 •
edited

Codecov Report

Merging #10804 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #10804   +/-   ##
=========================================
  Coverage     19.56%   19.56%           
  Complexity      631      631           
=========================================
  Files           362      362           
  Lines         15005    15005           
  Branches       2033     2033           
=========================================
  Hits           2935     2935           
  Misses        11793    11793           
  Partials        277      277

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ce9fbc...ca4ceeb. Read the comment docs.

@rocketsroger rocketsroger reopened this May 20, 2020
liuche
liuche approved these changes May 21, 2020
View reviewed changes
docs/crash-reporting.md Outdated
@@ -28,10 +30,14 @@ These crashes contain hardware information and some app metadata, but no persona

A sample Firefox Preview crash report can be found [here](https://crash-stats.mozilla.org/report/index/bbbcc019-f30c-4fbb-8cbd-543940190923).

To opt in or out of Socorro crash reporting, tap on reporting or dismiss the notification / dialog. This is an option on a per crash basis.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say instead "A crash report is only sent when the user confirms and submits it through the crash reporter dialog. Crash reports are never automatically sent." to make it clear. (and below)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I'll update.

@rocketsroger rocketsroger merged commit e07e629 into mozilla-mobile:master May 21, 2020
@rocketsroger rocketsroger deleted the FB_10802 branch May 21, 2020 23:42
@liuche liuche mentioned this pull request Jun 10, 2020
Closed
29 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@liuche liuche liuche approved these changes

Assignees

@liuche liuche

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rocketsroger @codecov-commenter @liuche