This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Amejia481
reviewed
Jun 1, 2020
Amejia481
reviewed
Jun 1, 2020
NotWoods
force-pushed
the
phone-feature
branch
2 times, most recently
from
June 3, 2020 19:28
5bdf7bb
to
14ccabd
Compare
Codecov Report
@@ Coverage Diff @@
## master #10810 +/- ##
============================================
- Coverage 20.46% 20.17% -0.29%
+ Complexity 680 675 -5
============================================
Files 372 375 +3
Lines 15442 15252 -190
Branches 2081 2065 -16
============================================
- Hits 3160 3077 -83
+ Misses 11986 11888 -98
+ Partials 296 287 -9
Continue to review full report at Codecov.
|
After doing some manual testing I noticed granted/denied site permissions are not showing in the toolbar video. I was testing with https://permission.site/ |
Whoops, used && instead of || after the rebase. I moved the visibility check into the view, since its coupled to the displayed permissions. |
Amejia481
approved these changes
Jun 8, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work 🚢 !
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gets rid of a lot of phone feature related code.
Pull Request checklist
After merge
To download an APK when reviewing a PR: