Issue:116, Issue:173 Verify the nav toolbar buttons[UI Tests] #10822

TejaswiKarasani · 2020-05-21T14:55:22Z

Pull Request checklist

Tests: This PR includes thorough tests or an explanation of why it does not
Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

After merge

Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

click on Show All Checks,
click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
click on the "Fenix - assemble" task, then click "Run Artifacts".
the APK links should be on the left side of the screen, named for each CPU architecture

codecov-commenter · 2020-05-21T15:07:23Z

Codecov Report

Merging #10822 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #10822   +/-   ##
=========================================
  Coverage     19.63%   19.63%           
  Complexity      632      632           
=========================================
  Files           363      363           
  Lines         14975    14975           
  Branches       2017     2017           
=========================================
  Hits           2940     2940           
  Misses        11756    11756           
  Partials        279      279

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d54dbce...247c2d5. Read the comment docs.

isabelrios · 2020-05-21T16:45:03Z

app/src/androidTest/java/org/mozilla/fenix/ui/SmokeTest.kt

+                verifyNavURLBar()
+                clickTabCounter()
+
+                // Verify items on HomeScreen


From Browser robot you should use the openHomescreen transition to go to Homescreen and then once there use its robots methods for checking that you are there, going to other menus from there...otherwise you are adding code from that robot to the BrowserRobot

yeah got that. So, that might be the test failure in emulator may be?

Do you mean in this way?

yes, something like that 👍

But when function clickTabCounter() is used it will take us to homescreen automatically. Hence, again using transition openHomeScreen causing error as it is already taken to the homescreen on clicking the number of tabs button.

So, I tried that, and locally is working:

verifyNavURLBar() }.openHomeScreen { verifyHomeScreen() verifyExistingTabList() }

I think the issue is in after the pressBack() that the test does not wait enough until the website is loaded to continue.
To be sure, try adding TestAssetHelper.waitingTime after that pressBack() if test passes, we will try to find a way to be sure the website is loaded.

It's seems you missed out adding 'clickTabCounter' function🤔

One of the steps mentioned in testrail is that one needs to click on tab counter and later check whether it's returning back to home screen

No, I didn't, it can go from navigation to homescreen if there is a transition defined...
https://github.com/mozilla-mobile/fenix/blob/master/app/src/androidTest/java/org/mozilla/fenix/ui/robots/BrowserRobot.kt#L338

you are tapping on tabCounter there

Oops,I should have gone through it carefully. Thanks for pointing out :)

I will rectify and push the code again.

After pushing the code, test is failing again!

isabelrios · 2020-05-25T15:33:03Z

app/src/androidTest/java/org/mozilla/fenix/ui/SmokeTest.kt

+                TestAssetHelper.waitingTime
+
+                // Verify various items after returning back to the initial WebPage
+                verifyPageContent(defaultWebPage.content)


@TejaswiKarasani I think the error you are seeing comes from this line...can you try to wait longer just to check that? if it still fails, try commenting out this line...thinking about more options here in the meantime...

Other option may be to check the content in the url bar...and see if that works...

Other option may be to check the content in the url bar...and see if that works...

When I saw in UI Automator, I couldn't find any specific id for the content in the url bar, I just found the whole url under one id

there is text (although I'm not sure you can say starts with...the port number will change each time)

Yeah, I thought it was the whole red highlight box and didn't struck my mind that it is for text inside the red box and by the way there is some particular function for testhelper.longWaitingTime or testhelper.longWaitingTime...and set time for minutes and seconds? or should I create a separate function for the long waiting time

you may be able to use one off those

Yeah cool.!

isabelrios · 2020-05-25T16:02:59Z

app/src/androidTest/java/org/mozilla/fenix/ui/SmokeTest.kt

+
+                // Verify items on HomeScreen
+                verifyHomeScreen()
+                verifyExistingTabList()


Oh and if I'm not mistaken, we are missing here step 6:

Back on the page, tap the menu button.
Expected Result
The main menu is displayed.

Yeah I missed that since that text was long, I forgot to expand the excel sheet :/. Thanks for the check :)

isabelrios · 2020-05-26T14:38:46Z

app/src/androidTest/java/org/mozilla/fenix/ui/SmokeTest.kt

+
+                // Verify various items after returning back to the initial WebPage
+                verifyNavURLBar()
+                verifyUrl((defaultWebPage.url).toString())


oh, now test is failing here, it does not find the urlBar element...it is like nothing in that page is seen when running the test...what about tryiing to add aftter line 58 this:
browserScreen { verifyNavURLBar() verifyUrl((defaultWebPage.url).toString()) }

Kind of forcing to say where you are.. and then continue with .openHomeScreen{....} at least locally that works...worth trying...

Is this the approach you were suggesting or should I supposed to add any other?

that's right but change the name, is not openBrowserScreen but just browserScreen

that's right but change the name, is not openBrowserScreen but just browserScreen

There isn't any transition named browserScreen , I think I need to create one should I go ahead with that one? Sorry for so many follow ups :/

it is not a transition, it is a function in BrowserRobot

Issue:116, Issue:173 Verify the nav toolbar buttons

ed91ab7

TejaswiKarasani requested review from isabelrios and rpappalax May 21, 2020 14:55

isabelrios reviewed May 21, 2020

View reviewed changes

TejaswiKarasani mentioned this pull request May 21, 2020

[UITests] BrowserRobot verifyPageContent() fails on random tests #10642

Closed

Used a transition OpenHomeScreen

b63f707

isabelrios reviewed May 25, 2020

View reviewed changes

Changed the logic part to verify page content to check the specific URL

a8b55a2

isabelrios reviewed May 26, 2020

View reviewed changes

TejaswiKarasani added 12 commits May 26, 2020 23:06

Used browserScreen for conveying the test about the location

13d03df

Trying out with VerifyPageContent

42c8794

Removed VerifyNavURL

3bff7d0

Commented out the verifyContent and added NavURL back

70f2b66

Commented out verifyNavURLBar()

d0e222b

Added a long time duration

73b002a

local changes

0820e9e

updating master to get it sync

0390a60

commented out both of the verifyNavURL and verifyPageContent()

2728c70

commented out verifyXButtonActions() and TestAssetHelper.waitingTime

8400c2b

ucommented verifyPageContent()

ca918d1

fixed ktlint issue

247c2d5

TejaswiKarasani closed this May 28, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Issue:116, Issue:173 Verify the nav toolbar buttons[UI Tests] #10822

Issue:116, Issue:173 Verify the nav toolbar buttons[UI Tests] #10822

TejaswiKarasani commented May 21, 2020

codecov-commenter commented May 21, 2020 •

edited

Loading

isabelrios May 21, 2020 •

edited

Loading

TejaswiKarasani May 21, 2020

TejaswiKarasani May 22, 2020

isabelrios May 22, 2020

TejaswiKarasani May 22, 2020

isabelrios May 22, 2020

TejaswiKarasani May 22, 2020 •

edited

Loading

isabelrios May 22, 2020 •

edited

Loading

TejaswiKarasani May 22, 2020 •

edited

Loading

TejaswiKarasani May 23, 2020

isabelrios May 25, 2020

TejaswiKarasani May 25, 2020

isabelrios May 25, 2020

TejaswiKarasani May 25, 2020 •

edited

Loading

isabelrios May 25, 2020

TejaswiKarasani May 25, 2020 •

edited

Loading

isabelrios May 25, 2020

TejaswiKarasani May 25, 2020

isabelrios May 25, 2020

TejaswiKarasani May 25, 2020

isabelrios May 26, 2020

TejaswiKarasani May 26, 2020 •

edited

Loading

isabelrios May 26, 2020

TejaswiKarasani May 26, 2020

isabelrios May 26, 2020

Issue:116, Issue:173 Verify the nav toolbar buttons[UI Tests] #10822

Issue:116, Issue:173 Verify the nav toolbar buttons[UI Tests] #10822

Conversation

TejaswiKarasani commented May 21, 2020

Pull Request checklist

After merge

To download an APK when reviewing a PR:

codecov-commenter commented May 21, 2020 • edited Loading

Codecov Report

isabelrios May 21, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TejaswiKarasani May 22, 2020 • edited Loading

Choose a reason for hiding this comment

isabelrios May 22, 2020 • edited Loading

Choose a reason for hiding this comment

TejaswiKarasani May 22, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TejaswiKarasani May 25, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TejaswiKarasani May 25, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TejaswiKarasani May 26, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov-commenter commented May 21, 2020 •

edited

Loading

isabelrios May 21, 2020 •

edited

Loading

TejaswiKarasani May 22, 2020 •

edited

Loading

isabelrios May 22, 2020 •

edited

Loading

TejaswiKarasani May 22, 2020 •

edited

Loading

TejaswiKarasani May 25, 2020 •

edited

Loading

TejaswiKarasani May 25, 2020 •

edited

Loading

TejaswiKarasani May 26, 2020 •

edited

Loading