Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

for #10753: improves the clickAddBookmarkButton method in flaky tests #10842

Merged
merged 1 commit into from May 22, 2020

Conversation

sv-ohorvath
Copy link
Contributor

@sv-ohorvath sv-ohorvath commented May 22, 2020

Fix for #10753: Espresso single click action is sometimes doing a long-click and it's a known issue. Google recommends a no-op rollback action.

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@sv-ohorvath sv-ohorvath requested a review from AaronMT May 22, 2020 07:49
@sv-ohorvath sv-ohorvath self-assigned this May 22, 2020
@sv-ohorvath sv-ohorvath added the eng:automation Build automation, Continuous integration, .. label May 22, 2020
@codecov-commenter
Copy link

codecov-commenter commented May 22, 2020

Codecov Report

Merging #10842 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #10842   +/-   ##
=========================================
  Coverage     19.63%   19.63%           
  Complexity      631      631           
=========================================
  Files           363      363           
  Lines         14941    14941           
  Branches       2015     2015           
=========================================
+ Hits           2933     2934    +1     
+ Misses        11731    11730    -1     
  Partials        277      277           
Impacted Files Coverage Δ Complexity Δ
...ix/home/sessioncontrol/SessionControlController.kt 72.07% <0.00%> (+0.90%) 0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e213521...fa26b56. Read the comment docs.

// wait for main menu to disappear
mDevice.waitNotNull(
Until.gone(By.res("mozac_browser_menu_recyclerView"))
addBookmarkButton().perform(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add a comment

/* no-op rollback action for when clicks randomly perform a long click, Espresso should attempt to click again
   https://issuetracker.google.com/issues/37078920#comment9 
*/

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
eng:automation Build automation, Continuous integration, ..
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants