Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

No issue: Disable verifyBasicNavigationToolbarFunctionality #11643

Merged
merged 1 commit into from
Jun 16, 2020

Conversation

AaronMT
Copy link
Contributor

@AaronMT AaronMT commented Jun 16, 2020

Disabling this test as it's triggering a native crash in GeckoView #11642

@AaronMT AaronMT added eng:disabled-test For any test that has been disabled eng:ui-test UI Tests labels Jun 16, 2020
@AaronMT AaronMT requested a review from isabelrios June 16, 2020 15:08
@AaronMT AaronMT self-assigned this Jun 16, 2020
@@ -21,6 +22,8 @@ import org.mozilla.fenix.ui.robots.navigationToolbar
* Test Suite that contains tests defined as part of the Smoke and Sanity check defined in Test rail.
* These tests will verify different functionalities of the app as a way to quickly detect regressions in main areas
*/

@Ignore("Temp disable for triggering a native Gecko crash - https://github.com/mozilla-mobile/fenix/issues/11642")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we ignore the test instead of the class? the idea is to add more tests to this class shortly...we can do that change in future PR...as you prefer...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, feel free to drop it to the test level when you update the test next.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will keep this in my mind while working on the next test. Thanks for disabling this test for now.

@codecov-commenter
Copy link

Codecov Report

Merging #11643 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #11643   +/-   ##
=========================================
  Coverage     21.54%   21.54%           
  Complexity      700      700           
=========================================
  Files           373      373           
  Lines         15072    15071    -1     
  Branches       2036     2036           
=========================================
  Hits           3247     3247           
+ Misses        11543    11542    -1     
  Partials        282      282           
Impacted Files Coverage Δ Complexity Δ
app/src/main/java/org/mozilla/fenix/Config.kt 33.33% <0.00%> (ø) 2.00% <0.00%> (ø%)
...ug/java/org/mozilla/fenix/DebugFenixApplication.kt 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b4c46f...89bc4c1. Read the comment docs.

@AaronMT AaronMT merged commit 0eae312 into mozilla-mobile:master Jun 16, 2020
@AaronMT AaronMT deleted the disable-smokeTest-UI-test branch June 30, 2020 13:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
eng:disabled-test For any test that has been disabled eng:ui-test UI Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants