Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #11651 - Fix top site favicon size and dark theme border color. #11652

Merged
merged 1 commit into from Jun 16, 2020

Conversation

person808
Copy link
Contributor

@person808 person808 commented Jun 16, 2020

Fixes #11651

Screenshot_1592333591

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

Copy link
Contributor

@liuche liuche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

icon changes and color update

@liuche liuche merged commit 291a29b into mozilla-mobile:master Jun 16, 2020
@person808 person808 deleted the top-site-fixes branch June 16, 2020 21:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Top site icon size and dark theme border doesn't match spec
2 participants