Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

for #11615 allowed strictMode disk read for violations made by the OS. #11658

Merged
merged 1 commit into from
Jun 21, 2020

Conversation

sraturi
Copy link
Contributor

@sraturi sraturi commented Jun 16, 2020

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@sraturi sraturi requested a review from MarcLeclair June 16, 2020 21:06
@sraturi sraturi linked an issue Jun 16, 2020 that may be closed by this pull request
@codecov-commenter
Copy link

Codecov Report

Merging #11658 into master will increase coverage by 0.00%.
The diff coverage is 10.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #11658   +/-   ##
=========================================
  Coverage     21.53%   21.53%           
+ Complexity      700      699    -1     
=========================================
  Files           374      374           
  Lines         15077    15080    +3     
  Branches       2037     2037           
=========================================
+ Hits           3247     3248    +1     
- Misses        11548    11551    +3     
+ Partials        282      281    -1     
Impacted Files Coverage Δ Complexity Δ
...rc/main/java/org/mozilla/fenix/FenixApplication.kt 12.58% <0.00%> (-0.09%) 4.00 <0.00> (ø)
.../java/org/mozilla/fenix/browser/BrowserFragment.kt 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...n/java/org/mozilla/fenix/IntentReceiverActivity.kt 71.79% <50.00%> (-1.18%) 6.00 <0.00> (ø)
...mozilla/fenix/components/metrics/ActivationPing.kt 73.68% <0.00%> (-5.27%) 5.00% <0.00%> (-1.00%)
app/src/main/java/org/mozilla/fenix/Config.kt 33.33% <0.00%> (ø) 2.00% <0.00%> (ø%)
.../fenix/browser/browsingmode/BrowsingModeManager.kt 100.00% <0.00%> (+14.28%) 0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36b1c71...b6f6718. Read the comment docs.

Copy link
Contributor

@MarcLeclair MarcLeclair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and worked on my g5 and px4 😄

@sraturi sraturi merged commit 9269a53 into mozilla-mobile:master Jun 21, 2020
@liuche liuche mentioned this pull request Jun 27, 2020
12 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix dangling strictmode violations on startup
3 participants