Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #11642 & #10642: Disable intermittent tests #11724

Merged
merged 2 commits into from
Jun 18, 2020
Merged

Conversation

sv-ohorvath
Copy link
Contributor

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@sv-ohorvath sv-ohorvath self-assigned this Jun 18, 2020
@sv-ohorvath sv-ohorvath added eng:intermittent-test Evil test failures that only happen now-and-then and are a productivity killer eng:ui-test UI Tests labels Jun 18, 2020
@codecov-commenter
Copy link

codecov-commenter commented Jun 18, 2020

Codecov Report

Merging #11724 into master will increase coverage by 0.16%.
The diff coverage is 25.80%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #11724      +/-   ##
============================================
+ Coverage     21.55%   21.72%   +0.16%     
- Complexity      700      715      +15     
============================================
  Files           374      375       +1     
  Lines         15067    15116      +49     
  Branches       2035     2040       +5     
============================================
+ Hits           3248     3284      +36     
- Misses        11538    11549      +11     
- Partials        281      283       +2     
Impacted Files Coverage Δ Complexity Δ
...a/org/mozilla/fenix/addons/AddonDetailsFragment.kt 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...g/mozilla/fenix/addons/AddonsManagementFragment.kt 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...c/main/java/org/mozilla/fenix/addons/Extensions.kt 0.00% <ø> (ø) 0.00 <0.00> (ø)
...ozilla/fenix/library/bookmarks/BookmarkFragment.kt 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...rg/mozilla/fenix/library/history/HistoryAdapter.kt 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...g/mozilla/fenix/library/history/HistoryFragment.kt 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...a/org/mozilla/fenix/library/history/HistoryView.kt 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...y/history/viewholders/HistoryListItemViewHolder.kt 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...illa/fenix/library/history/HistoryFragmentStore.kt 57.14% <13.33%> (-20.28%) 1.00 <0.00> (ø)
.../java/org/mozilla/fenix/addons/AddonDetailsView.kt 97.29% <97.29%> (ø) 15.00 <15.00> (?)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ce4aa1...f7a86ac. Read the comment docs.

@sv-ohorvath sv-ohorvath merged commit ed41c97 into master Jun 18, 2020
@sv-ohorvath sv-ohorvath deleted the disableTests branch June 18, 2020 08:59
@AaronMT
Copy link
Contributor

AaronMT commented Jun 18, 2020

So this doesn't get lost, cross-referencing to https://bugzilla.mozilla.org/show_bug.cgi?id=1644561 and #11642 to remember to actually re-enable these when the crash is fixed

@liuche liuche mentioned this pull request Jun 27, 2020
12 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
eng:intermittent-test Evil test failures that only happen now-and-then and are a productivity killer eng:ui-test UI Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants