-
Notifications
You must be signed in to change notification settings - Fork 1.3k
for #10568 Make Search Fragment xml include toolbar and AwesomeBar #11744
Conversation
Run 1 is a fresh install. Run 2 is stopping the application and restarting in 10 seconds. PROFILES Run 1 Master: https://share.firefox.dev/3ehngV9 STATS
TLDR: improvement Fresh install inflation time = 130.666 (Master) - 122.333(Changes) = inflation time reduce by 8.336 MS Second Run inflation time = 98 (Master) - 85(Changes) = inflation time reduced by 13 MS |
Codecov Report
@@ Coverage Diff @@
## master #11744 +/- ##
============================================
- Coverage 21.81% 21.80% -0.01%
Complexity 716 716
============================================
Files 375 375
Lines 15048 15063 +15
Branches 1952 1956 +4
============================================
+ Hits 3283 3285 +2
- Misses 11482 11495 +13
Partials 283 283
Continue to review full report at Codecov.
|
70d79b9
to
9fa0289
Compare
Moved toolbar inside search fragment
@@ -82,14 +79,9 @@ interface AwesomeBarInteractor { | |||
*/ | |||
class AwesomeBarView( | |||
private val container: ViewGroup, | |||
val interactor: AwesomeBarInteractor | |||
) : LayoutContainer { | |||
val view: BrowserAwesomeBar = LayoutInflater.from(container.context) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed, we don't need this any more because we have this logic here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested in regular tabs & custom tabs, didn't seem to have any issues. Code looks good 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested too and looks good on my end too
Pull Request checklist
After merge
To download an APK when reviewing a PR: