Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #11642: disables crashing UI test privateModeScreenItemsTest #11768

Merged
merged 1 commit into from
Jun 19, 2020

Conversation

sv-ohorvath
Copy link
Contributor

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@sv-ohorvath sv-ohorvath self-assigned this Jun 19, 2020
@sv-ohorvath sv-ohorvath added eng:ui-test UI Tests eng:intermittent-test Evil test failures that only happen now-and-then and are a productivity killer labels Jun 19, 2020
@sv-ohorvath sv-ohorvath requested a review from mcarare June 19, 2020 12:46
@codecov-commenter
Copy link

codecov-commenter commented Jun 19, 2020

Codecov Report

Merging #11768 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #11768   +/-   ##
=========================================
  Coverage     21.92%   21.92%           
  Complexity      716      716           
=========================================
  Files           376      376           
  Lines         15054    15055    +1     
  Branches       1954     1954           
=========================================
+ Hits           3300     3301    +1     
  Misses        11472    11472           
  Partials        282      282           
Impacted Files Coverage Δ Complexity Δ
...ug/java/org/mozilla/fenix/DebugFenixApplication.kt 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
app/src/main/java/org/mozilla/fenix/Config.kt 36.11% <0.00%> (+2.77%) 2.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0fe1a4...5ed2c6a. Read the comment docs.

@sv-ohorvath sv-ohorvath merged commit 76266c8 into master Jun 19, 2020
@sv-ohorvath sv-ohorvath deleted the disableCrashingTest branch June 19, 2020 13:14
@liuche liuche mentioned this pull request Jun 27, 2020
12 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
eng:intermittent-test Evil test failures that only happen now-and-then and are a productivity killer eng:ui-test UI Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants