Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #12026 - Update default top sites for new users #12028

Merged
merged 1 commit into from Jun 26, 2020
Merged

For #12026 - Update default top sites for new users #12028

merged 1 commit into from Jun 26, 2020

Conversation

gabrielluong
Copy link
Member

@gabrielluong gabrielluong commented Jun 26, 2020 •
edited

Pull Request checklist

Fixes #12026

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@gabrielluong gabrielluong requested a review from ekager June 26, 2020 20:22
@gabrielluong gabrielluong force-pushed the google branch 2 times, most recently from c96c242 to 9420c7b Compare June 26, 2020 20:24
ekager
ekager approved these changes Jun 26, 2020
View reviewed changes
Copy link
Contributor

@ekager ekager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Did you check if the icon looks alright too?

@gabrielluong
Copy link
Member Author

Looks good! Did you check if the icon looks alright too?

Yep they look fine to me. Screenshot for comparison:

Screen Shot 2020-06-26 at 4 29 56 PM

@gabrielluong gabrielluong merged commit e6a56ae into mozilla-mobile:master Jun 26, 2020
@gabrielluong gabrielluong deleted the google branch June 26, 2020 21:51
@liuche liuche mentioned this pull request Jun 27, 2020
Closed
12 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@miladmaz12 miladmaz12 miladmaz12 left review comments

@ekager ekager ekager approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update default top sites (for new users)
3 participants
@gabrielluong @miladmaz12 @ekager