-
Notifications
You must be signed in to change notification settings - Fork 1.3k
For #11655: add leanplum event for installing an addon #12136
Conversation
Request for data collection review formAll questions are mandatory. You must receive review from a data steward peer on your responses to these questions before shipping new data collection.
To measure how often addons are installed.
This will drive the CFR/mobile marketing automation, this will aid feature discovery for the users.
This data will be present as long as the user ID exists in Leanplum. LeanPlum does not support expiry dates for probes, but the mobile engagement/marketing automation teams will track this. @cbonacuse is the first contact here.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great. Ready to merge pending data approval from @boek
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume this was a copypasta error, but the data request is about tracking protection, not addon usage. Please update the request form! @jhugman
Data Review Form (to be filled by Data Stewards)
- Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?
addon addition is documented in mma.md
- Is there a control mechanism that allows the user to turn the data collection on and off?
Yes, Leanplum collection is covered by Fenix data controls
- If the request is for permanent data collection, is there someone who will monitor the data over time?
We should review Leanplum probes every 6 mo, and @cbonacuse from Mobile Engagement will monitor. @cbonacuse is also looking into how we might get LeanPlum automatic expiry.
- Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?
Type 2, interaction with addons by adding one
- Is the data collection request for default-on or default-off?
Default on
- Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?
No
- Is the data collection covered by the existing Firefox privacy notice?
Yes
- Does there need to be a check-in in the future to determine whether to renew the data? (Yes/No) (If yes, set a todo reminder or file a bug if appropriate)**
Yes, @liuche will schedule an MMA checkin with @cbonacuse for 6mo from now
- Does the data collection use a third-party collection tool?
Leanplum, which is approved for this type of collection.
6fe5039
to
26760a5
Compare
26760a5
to
c54222a
Compare
Fixes #11655.
This PR adds a metrics
Event
fired when the user has successfully installed an addon from the addon manager.It further enables the event to be logged as a LeanPlum event. It is not enabled as a Glean event.
The data-review will occur in this PR.
Pull Request checklist
[ ] Tests: This PR includes thorough tests or an explanation of why it does not[ ] Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not[ ] Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.After merge
To download an APK when reviewing a PR: