This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Fixes #11642 - Re-enable disabled UI-tests #12142
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nits: for fixing the ktlint otherwise this looks good
|
rpappalax
added
eng:ui-test
UI Tests
eng:automation
Build automation, Continuous integration, ..
labels
Jun 30, 2020
rpappalax
changed the title
(WIP) Fixes #11642 - Re-enable disabled UI-tests - DO NOT LAND
Fixes #11642 - Re-enable disabled UI-tests
Jun 30, 2020
rpappalax
added
pr:needs-landing
PRs that are ready to land [Will be merged by Mergify]
and removed
pr:do-not-land
labels
Jul 1, 2020
These were run 50 times without incident |
There was one failure for
Looks like some sort of strict mode violation from the video.
|
kbrosnan
approved these changes
Jul 1, 2020
Oh, good to know. This isn't one of the test we're re-enabling, so creating new issue: #12161 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
eng:automation
Build automation, Continuous integration, ..
eng:ui-test
UI Tests
pr:needs-landing
PRs that are ready to land [Will be merged by Mergify]
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11642
Pull Request checklist
After merge
To download an APK when reviewing a PR: