Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Add links in Checks panel for test/lint tasks #12222

Merged
merged 3 commits into from
Jul 10, 2020

Conversation

NotWoods
Copy link
Contributor

@NotWoods NotWoods commented Jul 3, 2020

Makes it easier to see the HTML artifact files :)

If you click on the "Checks" tab above, you'll see links to HTML files in test-debug, lint-lint, and lint-detekt. With this change we'll rarely have to open Taskcluster.

@NotWoods NotWoods added the eng:automation Build automation, Continuous integration, .. label Jul 3, 2020
@NotWoods NotWoods changed the title Add lints in Checks panel for test/lint tasks Add links in Checks panel for test/lint tasks Jul 3, 2020
@NotWoods NotWoods closed this Jul 3, 2020
@NotWoods NotWoods reopened this Jul 3, 2020
@NotWoods NotWoods closed this Jul 7, 2020
@NotWoods NotWoods reopened this Jul 7, 2020
@NotWoods NotWoods closed this Jul 7, 2020
@NotWoods NotWoods reopened this Jul 7, 2020
@NotWoods NotWoods closed this Jul 8, 2020
@NotWoods NotWoods reopened this Jul 8, 2020
Copy link
Contributor

@eliserichards eliserichards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits re: naming, but this looks great overall! Do you have any screenshots/mock-ups that show the final product?

build.gradle Outdated Show resolved Hide resolved
build.gradle Outdated Show resolved Hide resolved
@eliserichards eliserichards requested a review from liuche July 9, 2020 17:34
@eliserichards
Copy link
Contributor

I want approval from @liuche to make these changes to our PR Checks before we merge this 👍

Copy link
Contributor

@eliserichards eliserichards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gorgeous 🔥

@NotWoods NotWoods closed this Jul 9, 2020
@NotWoods NotWoods reopened this Jul 9, 2020
@NotWoods NotWoods closed this Jul 9, 2020
@NotWoods NotWoods reopened this Jul 9, 2020
@liuche
Copy link
Contributor

liuche commented Jul 10, 2020

@rpappalax this seems relevant to the work that you've been doing with linking to the CI failures within the Details page.

See https://github.com/mozilla-mobile/fenix/pull/12222/checks?check_run_id=855627859 for it working in this PR. Is there more that you think you + @NotWoods might want to talk/collaborate on?

@liuche liuche merged commit da87727 into mozilla-mobile:master Jul 10, 2020
@NotWoods NotWoods deleted the write-github-details branch July 10, 2020 18:41
@liuche liuche mentioned this pull request Jul 20, 2020
9 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
eng:automation Build automation, Continuous integration, ..
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants