-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Add links in Checks panel for test/lint tasks #12222
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few nits re: naming, but this looks great overall! Do you have any screenshots/mock-ups that show the final product?
buildSrc/src/main/java/org/mozilla/fenix/gradle/tasks/GithubDetailsTask.kt
Outdated
Show resolved
Hide resolved
I want approval from @liuche to make these changes to our PR Checks before we merge this 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gorgeous 🔥
df97cfd
to
386444c
Compare
@rpappalax this seems relevant to the work that you've been doing with linking to the CI failures within the Details page. See https://github.com/mozilla-mobile/fenix/pull/12222/checks?check_run_id=855627859 for it working in this PR. Is there more that you think you + @NotWoods might want to talk/collaborate on? |
Makes it easier to see the HTML artifact files :)
If you click on the "Checks" tab above, you'll see links to HTML files in test-debug, lint-lint, and lint-detekt. With this change we'll rarely have to open Taskcluster.