Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Bug 1652979 - Stop producing fennecNightly, fenixNightly and fenixBeta #12225

Merged
merged 6 commits into from Jul 21, 2020
Merged

Bug 1652979 - Stop producing fennecNightly, fenixNightly and fenixBeta #12225

merged 6 commits into from Jul 21, 2020

Conversation

JohanLorenzo
Copy link
Contributor

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@JohanLorenzo JohanLorenzo mentioned this pull request Jul 3, 2020
Merged
4 tasks
@JohanLorenzo JohanLorenzo added the pr:work-in-progress PRs that are not ready to be reviewed yet and are actively being worked on label Jul 3, 2020
@pocmo pocmo self-requested a review July 3, 2020 13:15
@pocmo pocmo self-assigned this Jul 3, 2020
gmierz
gmierz reviewed Jul 6, 2020
View reviewed changes
taskcluster/ci/browsertime/kind.yml Outdated
@@ -13,7 +13,7 @@ kind-dependencies:
primary-dependency: signing

only-for-build-types:
- nightly
- production
Copy link
Contributor

@gmierz gmierz Jul 6, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move this to the nightlySimulation build instead of production? (Same for raptor).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good news: This patch will rename production into nightly so this part won't change anymore. Do you still want me to use nightly-simulation? (I don't have any preference for now)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes please! We'll need to use nightly-simulation for sheriffing purposes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh! I just realized that if we change this to nightly-simulation then that would trigger it one every commit right? Then we'd have to make a cron for it.

I think it would be simpler for you to make the change to production and in the future when we get closer to sheriffing we'll make a cron and switch to the nightly-simulation build. How does that sound?

@gmierz
Copy link
Contributor

gmierz commented Jul 6, 2020

@JohanLorenzo can you ping me when this is about to land? It looks like we'll need to make changes in m-c for raptor/browsertime as well.

@pocmo
Copy link
Contributor

pocmo commented Jul 6, 2020

Note that Johan is out this week and we will continue this work next week :)

@JohanLorenzo JohanLorenzo changed the title [WIP] Bug 1649400 - part 4: Stop producing fennecNightly, fenixNightly and fenixBeta [WIP] Bug 1652979 - Stop producing fennecNightly, fenixNightly and fenixBeta Jul 15, 2020
@JohanLorenzo JohanLorenzo reopened this Jul 16, 2020
@JohanLorenzo JohanLorenzo reopened this Jul 17, 2020
@JohanLorenzo JohanLorenzo changed the title [WIP] Bug 1652979 - Stop producing fennecNightly, fenixNightly and fenixBeta Bug 1652979 - Stop producing fennecNightly, fenixNightly and fenixBeta Jul 21, 2020
@JohanLorenzo JohanLorenzo requested a review from gmierz July 21, 2020 11:39
@JohanLorenzo JohanLorenzo marked this pull request as ready for review July 21, 2020 11:39
@JohanLorenzo
Copy link
Contributor Author

JohanLorenzo commented Jul 21, 2020 •
edited

The patch was tested in the following graphs:

I need to handle the landing myself because I need to move these secrets https://firefox-ci-tc.services.mozilla.com/secrets/project%2Fmobile%2Ffenix%2Fproduction to https://firefox-ci-tc.services.mozilla.com/secrets/project%2Fmobile%2Ffenix%2Fnightly right after it lands.

pocmo
pocmo approved these changes Jul 21, 2020
View reviewed changes
Copy link
Contributor

@pocmo pocmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍

gmierz
gmierz approved these changes Jul 21, 2020
View reviewed changes
Copy link
Contributor

@gmierz gmierz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+ thanks!

@JohanLorenzo JohanLorenzo merged commit 7e7d69c into mozilla-mobile:master Jul 21, 2020
@JohanLorenzo JohanLorenzo deleted the bug-1649400-4 branch July 21, 2020 14:42
JohanLorenzo added a commit to JohanLorenzo/fenix that referenced this pull request Jul 21, 2020
@JohanLorenzo
Bug 1652979 - Stop producing fennecNightly, fenixNightly and fenixBeta (
493a83d 
mozilla-mobile#12225)
@JohanLorenzo JohanLorenzo mentioned this pull request Jul 21, 2020
Merged
4 tasks
JohanLorenzo added a commit to JohanLorenzo/fenix that referenced this pull request Jul 21, 2020
@JohanLorenzo
Bug 1652979 - Stop producing fennecNightly, fenixNightly and fenixBeta (
382616c 
mozilla-mobile#12225)
pocmo pushed a commit that referenced this pull request Jul 22, 2020
@JohanLorenzo @pocmo
Bug 1652979 - Stop producing fennecNightly, fenixNightly and fenixBeta (
fc24a90 
#12225)
@JohanLorenzo JohanLorenzo mentioned this pull request Jul 23, 2020
Merged
@mcomella mcomella mentioned this pull request Jul 24, 2020
Closed
mcomella added a commit to mcomella/fenix that referenced this pull request Jul 24, 2020
@mcomella
Revert "Bug 1652979 - Stop producing fennecNightly, fenixNightly and …
e0c4001 
…fenixBeta (mozilla-mobile#12225)"

This reverts commit 7e7d69c.

This caused the nightly FNPRMS tests to fail because the
`fennec-nightly` variant no longer exists. We could change the variant
but then the migration code is not covered. The least time consuming
solution for the FE perf team is to revert the change and atomically
implement the long term solution rather than making an intermediate
change now and another change after the long term solution arrives,
which would skew our dashboards (that we don't have the ability to
annotate) with multiple incomparable builds.
@mcomella mcomella mentioned this pull request Jul 24, 2020
Closed
4 tasks
@JohanLorenzo JohanLorenzo mentioned this pull request Jul 29, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pocmo pocmo pocmo approved these changes

@gmierz gmierz gmierz approved these changes

Assignees

@pocmo pocmo

Labels
pr:work-in-progress PRs that are not ready to be reviewed yet and are actively being worked on
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JohanLorenzo @gmierz @pocmo