Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #11886 - Re-enable codecov #12258

Merged
merged 3 commits into from Jul 13, 2020
Merged

Conversation

NotWoods
Copy link
Contributor

@NotWoods NotWoods commented Jul 3, 2020

Copies the script locally

@codecov-commenter
Copy link

codecov-commenter commented Jul 10, 2020

Codecov Report

Merging #12258 into master will increase coverage by 1.52%.
The diff coverage is 26.68%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #12258      +/-   ##
============================================
+ Coverage     22.12%   23.64%   +1.52%     
- Complexity      725      797      +72     
============================================
  Files           377      377              
  Lines         15098    15468     +370     
  Branches       1957     2017      +60     
============================================
+ Hits           3341     3658     +317     
- Misses        11469    11502      +33     
- Partials        288      308      +20     
Impacted Files Coverage Δ Complexity Δ
...in/java/org/mozilla/fenix/AppRequestInterceptor.kt 87.50% <0.00%> (ø) 6.00 <0.00> (ø)
app/src/main/java/org/mozilla/fenix/Config.kt 29.72% <0.00%> (-3.61%) 2.00 <0.00> (ø)
...pp/src/main/java/org/mozilla/fenix/FeatureFlags.kt 0.00% <ø> (-100.00%) 0.00 <0.00> (-1.00)
...rc/main/java/org/mozilla/fenix/FenixApplication.kt 12.32% <0.00%> (-0.09%) 4.00 <0.00> (ø)
...n/java/org/mozilla/fenix/IntentReceiverActivity.kt 72.97% <0.00%> (+1.17%) 6.00 <0.00> (ø)
...a/org/mozilla/fenix/addons/AddonDetailsFragment.kt 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...a/org/mozilla/fenix/browser/BaseBrowserFragment.kt 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../java/org/mozilla/fenix/browser/BrowserFragment.kt 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ava/org/mozilla/fenix/browser/UriOpenedObserver.kt 47.61% <0.00%> (+16.36%) 7.00 <4.00> (+3.00)
...main/java/org/mozilla/fenix/cfr/SearchWidgetCFR.kt 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
... and 171 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c265a70...8b98259. Read the comment docs.

@liuche
Copy link
Contributor

liuche commented Jul 11, 2020

Talk to @escapewindow about this (Aki from release engineering) but this was one of the approaches he suggested. We could also just land this and deal with any follow-ups later. Probably need some way to regularly check/pull this script though 🤔

@escapewindow
Copy link
Contributor

I think this is a good stopgap, or ongoing solution if a) we have something that regularly checks the script, and b) we can't get codecov to help debug and address the hanging issue.

@NotWoods NotWoods merged commit 67758ab into mozilla-mobile:master Jul 13, 2020
@NotWoods NotWoods deleted the codecov branch July 13, 2020 23:22
@liuche liuche mentioned this pull request Jul 20, 2020
9 tasks
@jonalmeida
Copy link
Contributor

Thanks for doing this work @NotWoods ! It saved us from the massive breach that took place. 🙃

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
eng:automation Build automation, Continuous integration, ..
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants