Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Remove the duplicated/outdated 'activation' ping docs #12421

Merged
merged 1 commit into from Jul 21, 2020

Conversation

Dexterp37
Copy link
Contributor

This additionally overhauls the Fenix telemetry docs to point at the Glean autogenerated docs, to prevent documentation getting outdated again.

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@AaronMT
Copy link
Contributor

AaronMT commented Jul 9, 2020

The ui-test-x86-debug error for the test indicated should be fixed in a more recent rebase.

@Dexterp37
Copy link
Contributor Author

The ui-test-x86-debug error for the test indicated should be fixed in a more recent rebase.

Yup, being a doc-only change I believe we could also just merge once review :-)

Copy link
Contributor

@liuche liuche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doc updates, lgtm!

This additionally overhauls the Fenix telemetry docs
to point at the Glean autogenerated docs, to prevent
documentation getting outdated again.
@liuche liuche merged commit b31564d into mozilla-mobile:master Jul 21, 2020
@Dexterp37 Dexterp37 deleted the activation_docs branch July 21, 2020 05:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants