This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We set up our dependencies inside the
Components
class, except forSettings
. This PR moves the Settings class into Components.Motivation
The
Settings
class is a singleton that isn't easily mocked. Tests involving settings vary from using static mocks, overriding the singleton, and manipulating the internal SharedPreferences. Moving it intoComponents
makes it easier to write tests by just using normal mocks.Settings
is probably a singleton just for historic reasons. A Settings singleton existed in Focus long before we had any components, and from there it made it to Fenix.