Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #12871 - Use local TWA DAL API #12872

Merged
merged 2 commits into from
Jul 24, 2020

Conversation

NotWoods
Copy link
Contributor

Who doesn't love acronyms?

Let's move off the Google API and call website APIs directly. I've been testing this system in Sample Browser and trying this branch out too. Everything works well and we can remove the related API key.

@codecov-commenter
Copy link

codecov-commenter commented Jul 23, 2020

Codecov Report

Merging #12872 into master will increase coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #12872      +/-   ##
============================================
+ Coverage     27.39%   27.40%   +0.01%     
  Complexity      984      984              
============================================
  Files           411      411              
  Lines         16255    16254       -1     
  Branches       2088     2088              
============================================
+ Hits           4453     4455       +2     
+ Misses        11477    11475       -2     
+ Partials        325      324       -1     
Impacted Files Coverage Δ Complexity Δ
...src/main/java/org/mozilla/fenix/components/Core.kt 25.00% <0.00%> (ø) 1.00 <0.00> (ø)
...ug/java/org/mozilla/fenix/DebugFenixApplication.kt 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
.../logins/controller/SavedLoginsStorageController.kt 42.10% <0.00%> (ø) 8.00% <0.00%> (ø%)
...mponents/searchengine/FenixSearchEngineProvider.kt 63.96% <0.00%> (+1.80%) 13.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cac0be4...8c71a5f. Read the comment docs.

Copy link
Contributor

@jonalmeida jonalmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM LRTETTMFT (let's remove the edits to the metrics file though)

@NotWoods NotWoods merged commit 8c1d3dc into mozilla-mobile:master Jul 24, 2020
@NotWoods NotWoods deleted the 12871_twa-local branch July 24, 2020 20:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants