Bug 1648785 - Let taskcluster upload APKs to Github releases #12907

JohanLorenzo · 2020-07-24T16:34:58Z

Pull Request checklist

Tests: This PR includes thorough tests or an explanation of why it does not
Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

After merge

Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

click on Show All Checks,
click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
click on the "Fenix - assemble" task, then click "Run Artifacts".
the APK links should be on the left side of the screen, named for each CPU architecture

JohanLorenzo · 2020-07-24T16:36:08Z

upcoming_release_notes.md

@@ -0,0 +1,3 @@
+Thanks for trying out Firefox Daylight! In {version}, we have lots of new improvements:


TODO for myself before landing: Tell the people in charge of releases about this file and how to update it.

TODO as a followup: Let bump task clobber this file.

For latter I've added a comment in https://bugzilla.mozilla.org/show_bug.cgi?id=1635488#c9 to track it when we add that support.

JohanLorenzo · 2020-07-24T16:36:37Z

taskcluster/fenix_taskgraph/transforms/browsertime.py

            if abi not in only_abis:
                continue
+            apk_path = apk_metadata["name"]


Nit for this PR: Rename name

I'll handle this in a followup PR. I don't remember what I did back in July so making this change in this PR adds some risk. I'd prefer to focus on getting this task up and running in production rather than fixing this kind of names.

taskcluster/fenix_taskgraph/worker_types.py

JohanLorenzo · 2020-07-24T16:38:41Z

taskcluster/ci/github-release/kind.yml

+group-by: build-type
+
+only-for-build-types:
+    - fennec-beta


TODO change build types once #12827 lands.

codecov-commenter · 2020-07-24T17:34:13Z

Codecov Report

Merging #12907 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master   #12907      +/-   ##
============================================
+ Coverage     29.22%   29.23%   +0.01%     
  Complexity     1161     1161              
============================================
  Files           454      454              
  Lines         18541    18540       -1     
  Branches       2393     2393              
============================================
+ Hits           5419     5421       +2     
+ Misses        12745    12742       -3     
  Partials        377      377

Impacted Files	Coverage Δ	Complexity Δ
...ug/java/org/mozilla/fenix/DebugFenixApplication.kt	`0.00% <0.00%> (ø)`	`0.00% <0.00%> (ø%)`
...mponents/searchengine/FenixSearchEngineProvider.kt	`63.96% <0.00%> (+1.80%)`	`13.00% <0.00%> (ø%)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f43476c...4d954e4. Read the comment docs.

taskcluster/ci/config.yml

MihaiTabara · 2020-07-29T17:00:00Z

upcoming_release_notes.md

@@ -0,0 +1,3 @@
+Thanks for trying out Firefox Daylight! In {version}, we have lots of new improvements:


For latter I've added a comment in https://bugzilla.mozilla.org/show_bug.cgi?id=1635488#c9 to track it when we add that support.

MihaiTabara · 2020-07-29T17:00:30Z

taskcluster/ci/build/kind.yml

@@ -20,6 +20,7 @@ job-defaults:
    # `name` and `path`.
    apk-artifact-template:
        type: file
+        github-name: "firefox_preview_v{version}_{abi}.apk"


Nit: did we want to update the name to s/preview/daylight?

MihaiTabara · 2020-07-29T17:00:49Z

taskcluster/ci/github-release/kind.yml

+                fennec-beta: true
+                fennec-release: false
+                default: true
+        release-name: Firefox Preview {version}


Nit: did we want to update the name to s/Sreview/Daylight?

MihaiTabara · 2020-07-29T17:06:51Z

taskcluster/fenix_taskgraph/transforms/github_release.py

+
+def _get_release_notes(config):
+    release_notes_path = os.path.join(config.graph_config.vcs_root, "upcoming_release_notes.md")
+    with codecs.open(release_notes_path, encoding="utf-8") as f:


MihaiTabara · 2020-07-29T17:28:51Z

taskcluster/fenix_taskgraph/transforms/github_release.py

+
+        yield task
+
+def _build_artifact_map(task):


+1 for the consistency with beetmover schemas, even though they are not related in practice, but only conceptually.

liuche · 2020-09-01T00:02:02Z

@JohanLorenzo is this still something that is able to be landed? I'm not sure what happened here, but would love to have it, especially if the work is done! looks like it got approved, but then CI broke?

liuche · 2020-09-01T15:46:25Z

can't wait! however why is CI still running after 9 hours :(

JohanLorenzo · 2020-09-02T09:17:32Z

Thanks for your interest in this @liuche 😃

We have an explanation about the CI timeouts. We need some new workers to be online. Releng depends on CloudOps to do so, and we face that problem https://bugzilla.mozilla.org/show_bug.cgi?id=1658298#c2. So, we can't merge this PR just yet. I'll keep you tuned.

JohanLorenzo · 2020-09-14T15:36:21Z

It now works and it's been tested end-to-end: https://firefox-ci-tc.services.mozilla.com/tasks/bGKyHzrGR-y0mOBzVx79pQ/runs/4/logs/https%3A%2F%2Ffirefox-ci-tc.services.mozilla.com%2Fapi%2Fqueue%2Fv1%2Ftask%2FbGKyHzrGR-y0mOBzVx79pQ%2Fruns%2F4%2Fartifacts%2Fpublic%2Flogs%2Flive_backing.log#L58

Staging will be a dummy task just like this one https://firefox-ci-tc.services.mozilla.com/tasks/Cku_lREtSVKlNF2mYcBVPQ/runs/1/logs/https%3A%2F%2Ffirefox-ci-tc.services.mozilla.com%2Fapi%2Fqueue%2Fv1%2Ftask%2FCku_lREtSVKlNF2mYcBVPQ%2Fruns%2F1%2Fartifacts%2Fpublic%2Flogs%2Flive_backing.log

This is ready to land and to be tested with the actual production environment.

JohanLorenzo commented Jul 24, 2020

View reviewed changes

MihaiTabara approved these changes Jul 29, 2020

View reviewed changes

boek added pr:needs-landing PRs that are ready to land [Will be merged by Mergify] and removed pr:needs-landing PRs that are ready to land [Will be merged by Mergify] labels Jul 29, 2020

JohanLorenzo force-pushed the bug-1648785 branch 3 times, most recently from 374aaa4 to 627a458 Compare August 7, 2020 09:56

JohanLorenzo closed this Sep 1, 2020

JohanLorenzo reopened this Sep 1, 2020

JohanLorenzo closed this Sep 14, 2020

JohanLorenzo reopened this Sep 14, 2020

JohanLorenzo force-pushed the bug-1648785 branch from 627a458 to e5f51c6 Compare September 14, 2020 08:59

Bug 1648785 - Let taskcluster upload APKs to Github releases

4d954e4

JohanLorenzo force-pushed the bug-1648785 branch from d81f293 to 4d954e4 Compare September 14, 2020 14:56

JohanLorenzo merged commit 779757f into mozilla-mobile:master Sep 14, 2020

JohanLorenzo deleted the bug-1648785 branch September 14, 2020 16:49

liuche mentioned this pull request Sep 16, 2020

Where can we download newest Firefox For Android except in Google Play? #15034

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bug 1648785 - Let taskcluster upload APKs to Github releases #12907

Bug 1648785 - Let taskcluster upload APKs to Github releases #12907

JohanLorenzo commented Jul 24, 2020

JohanLorenzo Jul 24, 2020

MihaiTabara Jul 29, 2020

JohanLorenzo Jul 24, 2020

JohanLorenzo Sep 14, 2020

JohanLorenzo Jul 24, 2020

codecov-commenter commented Jul 24, 2020 •

edited

MihaiTabara Jul 29, 2020

MihaiTabara Jul 29, 2020

MihaiTabara Jul 29, 2020

MihaiTabara Jul 29, 2020

MihaiTabara Jul 29, 2020

liuche commented Sep 1, 2020

liuche commented Sep 1, 2020

JohanLorenzo commented Sep 2, 2020

JohanLorenzo commented Sep 14, 2020

		@@ -0,0 +1,3 @@
		Thanks for trying out Firefox Daylight! In {version}, we have lots of new improvements:

Bug 1648785 - Let taskcluster upload APKs to Github releases #12907

Bug 1648785 - Let taskcluster upload APKs to Github releases #12907

Conversation

JohanLorenzo commented Jul 24, 2020

Pull Request checklist

After merge

To download an APK when reviewing a PR:

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov-commenter commented Jul 24, 2020 • edited

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

liuche commented Sep 1, 2020

liuche commented Sep 1, 2020

JohanLorenzo commented Sep 2, 2020

JohanLorenzo commented Sep 14, 2020

codecov-commenter commented Jul 24, 2020 •

edited