Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

FNX-14331 ⁃ Update README.md #13150

Merged
merged 1 commit into from
Jul 31, 2020
Merged

FNX-14331 ⁃ Update README.md #13150

merged 1 commit into from
Jul 31, 2020

Conversation

liuche
Copy link
Contributor

@liuche liuche commented Jul 31, 2020

We'll be redirecting people from bugzilla, and we've started Fennec rollout, so no time like the present to update references in the readme

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@codecov-commenter
Copy link

codecov-commenter commented Jul 31, 2020

Codecov Report

Merging #13150 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #13150   +/-   ##
=========================================
  Coverage     28.20%   28.20%           
  Complexity     1034     1034           
=========================================
  Files           417      417           
  Lines         16769    16769           
  Branches       2167     2167           
=========================================
  Hits           4729     4729           
  Misses        11696    11696           
  Partials        344      344           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ddf8be...2a0ac9d. Read the comment docs.

Copy link
Contributor

@NotWoods NotWoods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should continue to say explicitly that Fenix is an internal code name. Otherwise its unclear why the repo is named fenix and not firefox-android.

We'll be redirecting people from bugzilla, and we've started Fennec rollout, so no time like the present to update references in the readme
@liuche liuche merged commit a112770 into master Jul 31, 2020
@NotWoods NotWoods deleted the preview2firefox branch July 31, 2020 20:23
@data-sync-user data-sync-user changed the title Update README.md FNX-14331 ⁃ Update README.md Aug 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants