Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

FNX-14505 ⁃ Wires up controller, store and interactor. #13324

Merged
merged 2 commits into from
Aug 5, 2020

Conversation

boek
Copy link
Contributor

@boek boek commented Aug 5, 2020

For #13320, #13323

…interactor for the new search experience
@boek boek requested a review from eliserichards August 5, 2020 21:06
@codecov-commenter
Copy link

Codecov Report

Merging #13324 into master will decrease coverage by 0.14%.
The diff coverage is 3.52%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #13324      +/-   ##
============================================
- Coverage     28.40%   28.25%   -0.15%     
  Complexity     1046     1046              
============================================
  Files           420      421       +1     
  Lines         17010    17114     +104     
  Branches       2201     2231      +30     
============================================
+ Hits           4832     4836       +4     
- Misses        11830    11929      +99     
- Partials        348      349       +1     
Impacted Files Coverage Δ Complexity Δ
...pp/src/main/java/org/mozilla/fenix/HomeActivity.kt 6.34% <0.00%> (-0.03%) 11.00 <0.00> (ø)
...c/main/java/org/mozilla/fenix/home/HomeFragment.kt 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...zilla/fenix/searchdialog/SearchDialogController.kt 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...mozilla/fenix/searchdialog/SearchDialogFragment.kt 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...nix/components/toolbar/BrowserToolbarController.kt 70.10% <30.76%> (-2.62%) 0.00 <0.00> (ø)
...rc/main/java/org/mozilla/fenix/BrowserDirection.kt 100.00% <100.00%> (ø) 2.00 <0.00> (ø)
...mponents/searchengine/FenixSearchEngineProvider.kt 63.96% <0.00%> (+1.80%) 13.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6492773...60fd68f. Read the comment docs.

@@ -81,6 +81,9 @@ class DefaultBrowserToolbarController(
private val onCloseTab: (Session) -> Unit
) : BrowserToolbarController {

private val useNewSearchExperience
get() = activity.settings().useNewSearchExperience
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're moving to injecting dependencies in the constructor instead, Settings should be passed in via the constructor.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's put this into the next piece of the work @boek

Copy link
Contributor

@eliserichards eliserichards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! On to the next part 🥇

@eliserichards eliserichards merged commit ccb5b0b into mozilla-mobile:master Aug 5, 2020
@data-sync-user data-sync-user changed the title Wires up controller, store and interactor. FNX-14505 ⁃ Wires up controller, store and interactor. Aug 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants