-
Notifications
You must be signed in to change notification settings - Fork 1.3k
FNX-14505 ⁃ Wires up controller, store and interactor. #13324
Conversation
…interactor for the new search experience
…e browser when enabled
Codecov Report
@@ Coverage Diff @@
## master #13324 +/- ##
============================================
- Coverage 28.40% 28.25% -0.15%
Complexity 1046 1046
============================================
Files 420 421 +1
Lines 17010 17114 +104
Branches 2201 2231 +30
============================================
+ Hits 4832 4836 +4
- Misses 11830 11929 +99
- Partials 348 349 +1
Continue to review full report at Codecov.
|
@@ -81,6 +81,9 @@ class DefaultBrowserToolbarController( | |||
private val onCloseTab: (Session) -> Unit | |||
) : BrowserToolbarController { | |||
|
|||
private val useNewSearchExperience | |||
get() = activity.settings().useNewSearchExperience |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're moving to injecting dependencies in the constructor instead, Settings
should be passed in via the constructor.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's put this into the next piece of the work @boek
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! On to the next part 🥇
For #13320, #13323