Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Closes #12778: re-arranged steps to follow current flow in closeTabTest & closePrivateTabTest #13810

Merged
merged 1 commit into from Aug 13, 2020

Conversation

sv-ohorvath
Copy link
Contributor

@sv-ohorvath sv-ohorvath commented Aug 13, 2020

The tabs drawer is hidden after closing the last tab so you need to re-open the tab drawer to see the tab restore with Undo.

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

Copy link
Contributor

@AaronMT AaronMT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Thanks. Looks good to me.

@codecov-commenter
Copy link

codecov-commenter commented Aug 13, 2020

Codecov Report

Merging #13810 into master will decrease coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #13810      +/-   ##
============================================
- Coverage     28.39%   28.29%   -0.10%     
+ Complexity     1050     1048       -2     
============================================
  Files           421      421              
  Lines         17145    17188      +43     
  Branches       2233     2238       +5     
============================================
- Hits           4868     4864       -4     
- Misses        11929    11975      +46     
- Partials        348      349       +1     
Impacted Files Coverage Δ Complexity Δ
...in/java/org/mozilla/fenix/settings/SupportUtils.kt 71.42% <0.00%> (-4.09%) 11.00% <0.00%> (-2.00%)
...mponents/searchengine/FenixSearchEngineProvider.kt 62.16% <0.00%> (-1.81%) 13.00% <0.00%> (ø%)
...in/java/org/mozilla/fenix/search/SearchFragment.kt 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0a045f...354bc1e. Read the comment docs.

@AaronMT AaronMT merged commit 4542b4b into master Aug 13, 2020
@sv-ohorvath sv-ohorvath deleted the closeTabsTests branch August 14, 2020 07:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
eng:ui-test UI Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Intermittent UI test failure - TabbedBrowsingTest.closeTabTest & closePrivateTabTest
3 participants