Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Remove un-needed nullables #13816

Merged
merged 1 commit into from
Aug 28, 2020
Merged

Remove un-needed nullables #13816

merged 1 commit into from
Aug 28, 2020

Conversation

NotWoods
Copy link
Contributor

There are various spots where we could hold a reference to a singleton or simply crash if an asset is missing.

@codecov-commenter
Copy link

codecov-commenter commented Aug 13, 2020

Codecov Report

Merging #13816 into master will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #13816   +/-   ##
=========================================
  Coverage     29.91%   29.92%           
  Complexity     1157     1157           
=========================================
  Files           443      443           
  Lines         17845    17848    +3     
  Branches       2326     2323    -3     
=========================================
+ Hits           5339     5341    +2     
- Misses        12131    12132    +1     
  Partials        375      375           
Impacted Files Coverage Δ Complexity Δ
...a/org/mozilla/fenix/browser/BaseBrowserFragment.kt 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../java/org/mozilla/fenix/browser/BrowserAnimator.kt 11.76% <0.00%> (ø) 0.00 <0.00> (ø)
...in/java/org/mozilla/fenix/search/SearchFragment.kt 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../mozilla/fenix/search/awesomebar/AwesomeBarView.kt 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...mozilla/fenix/searchdialog/SearchDialogFragment.kt 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...tepermissions/SitePermissionsExceptionsFragment.kt 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...mponents/searchengine/FenixSearchEngineProvider.kt 63.96% <0.00%> (+1.80%) 13.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ace6b99...6c7fd33. Read the comment docs.

@NotWoods NotWoods merged commit a8291bf into mozilla-mobile:master Aug 28, 2020
@NotWoods NotWoods deleted the notnull branch August 28, 2020 20:28
TrianguloY pushed a commit to TrianguloY/fenix that referenced this pull request Sep 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
eng:health Improve code health
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants