Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #11465 - Fix default engine for widget voice search #14015

Conversation

codrut-topliceanu
Copy link
Contributor

For #11465

Pull Request checklist

  • Tests: This PR does not include any tests as it is only a minor change.
  • Screenshots: This PR includes a GIF.
  • Accessibility: The code in this PR follows accessibility best practices.

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

voice widget

@codecov-commenter
Copy link

codecov-commenter commented Aug 21, 2020

Codecov Report

Merging #14015 into master will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #14015      +/-   ##
============================================
- Coverage     29.67%   29.66%   -0.01%     
- Complexity     1133     1134       +1     
============================================
  Files           434      434              
  Lines         17483    17486       +3     
  Branches       2259     2260       +1     
============================================
  Hits           5188     5188              
- Misses        11916    11919       +3     
  Partials        379      379              
Impacted Files Coverage Δ Complexity Δ
...enix/settings/search/SearchEngineListPreference.kt 0.00% <0.00%> (ø) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a6e9bc...646dc3f. Read the comment docs.

@Mugurell Mugurell self-assigned this Aug 27, 2020
@Mugurell Mugurell self-requested a review August 27, 2020 10:29
@codrut-topliceanu
Copy link
Contributor Author

The issue seems to be located in SearchEngineListPreference.onCheckedChanged().
When a search engine is deleted onCheckedChanged() should be called, and then when...true -> onSearchEngineSelected(engine), however that never happens as wrapper is always null at that point.

Copy link
Contributor

@Mugurell Mugurell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this!

@Mugurell Mugurell merged commit 72edaaf into mozilla-mobile:master Sep 1, 2020
TrianguloY pushed a commit to TrianguloY/fenix that referenced this pull request Sep 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants