Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

No issue: Remove milestone from pull request template #14198

Merged
merged 1 commit into from Aug 26, 2020
Merged

Conversation

jonalmeida
Copy link
Contributor

We don't use milestones in Fenix, so let's remove it from the PR template.

Pull Request checklist

  • [n/a] Tests: This PR includes thorough tests or an explanation of why it does not
  • [n/a] Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • [n/a] Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

After merge

  • [nope] Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

We don't use milestones in Fenix, so let's remove it from the PR template.
@codecov-commenter
Copy link

codecov-commenter commented Aug 25, 2020

Codecov Report

Merging #14198 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #14198   +/-   ##
=========================================
  Coverage     29.58%   29.59%           
  Complexity     1135     1135           
=========================================
  Files           440      440           
  Lines         17689    17689           
  Branches       2299     2299           
=========================================
+ Hits           5234     5235    +1     
+ Misses        12073    12072    -1     
  Partials        382      382           
Impacted Files Coverage Δ Complexity Δ
...in/java/org/mozilla/fenix/settings/SupportUtils.kt 76.00% <0.00%> (+2.00%) 13.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb3fd4e...4b87044. Read the comment docs.

@liuche liuche merged commit f638935 into master Aug 26, 2020
@liuche liuche deleted the pr-template-fix branch August 26, 2020 01:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants