For #13926 - MP migration

[ekager]

Pull Request checklist

• Tests: This PR includes thorough tests or an explanation of why it does not
• Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
• Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

To download an APK when reviewing a PR:

1. click on Show All Checks,
2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
3. click on the "Fenix - assemble" task, then click "Run Artifacts".
4. the APK links should be on the left side of the screen, named for each CPU architecture

[codecov-commenter]

Codecov Report

Merging #14468 into master will decrease coverage by 0.24%.
The diff coverage is 3.16%.

@@             Coverage Diff              @@
##             master   #14468      +/-   ##
============================================
- Coverage     30.11%   29.86%   -0.25%     
  Complexity     1167     1167              
============================================
  Files           444      445       +1     
  Lines         17920    18074     +154     
  Branches       2333     2349      +16     
============================================
+ Hits           5396     5398       +2     
- Misses        12149    12300     +151     
- Partials        375      376       +1     

Impacted Files	Coverage Δ	Complexity Δ
...java/org/mozilla/fenix/components/metrics/Event.kt	32.01% <0.00%> (-0.22%)	0.00 <0.00> (ø)
...la/fenix/components/metrics/GleanMetricsService.kt	12.04% <0.00%> (-0.10%)	4.00 <0.00> (ø)
...onents/tips/providers/MasterPasswordTipProvider.kt	0.00% <0.00%> (ø)	0.00 <0.00> (?)
...c/main/java/org/mozilla/fenix/home/HomeFragment.kt	0.00% <0.00%> (ø)	0.00 <0.00> (ø)
...org/mozilla/fenix/home/tips/ButtonTipViewHolder.kt	80.64% <0.00%> (-5.57%)	4.00 <0.00> (ø)
.../logins/controller/SavedLoginsStorageController.kt	57.14% <ø> (ø)	8.00 <0.00> (ø)
...va/org/mozilla/fenix/components/tips/TipManager.kt	100.00% <100.00%> (ø)	0.00 <0.00> (ø)
.../src/main/java/org/mozilla/fenix/utils/Settings.kt	66.59% <100.00%> (+0.23%)	28.00 <0.00> (ø)
...mponents/searchengine/FenixSearchEngineProvider.kt	62.16% <0.00%> (-1.81%)	13.00% <0.00%> (ø%)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c748c0...2cfce3b. Read the comment docs.

[ekager]

gif of behavior w empty logins in Fenix. Also tested case where I had already saved a duplicate login in Fenix and it doesn't make a duplicate or crash. 👍

[ekager]

Request for data collection review form

All questions are mandatory. You must receive review from a data steward peer on your responses to these questions before shipping new data collection.

1. What questions will you answer with this data?

• How many users with Master Passwords clicked our homescreen tip to migrate their logins into Fenix?
• How many of those users successfully migrated their logins?

2. Why does Mozilla need to answer these questions? Are there benefits for users? Do we need this information to address product or business requirements?

• We want to know how many users successfully "rescued" their logins from Fennec using the master password.

3. What alternative methods did you consider to answer these questions? Why were they not sufficient?

• N/A (These are baseline metrics)

4. Can current instrumentation answer these questions?

• No, this is a one-time event

5. List all proposed measurements and indicate the category of data collection for each measurement, using the Firefox data collection categories on the found on the Mozilla wiki.

• All data is Category 2.

6. How long will this data be collected?

Until 03/01/2020

7. What populations will you measure?

• All migrated release, beta, and nightly users with telemetry enabled.

8. Please provide a general description of how you will analyze this data.

• Glean / Amplitude

9. Where do you intend to share the results of your analysis?

• Only on Glean, Amplitude and with mobile teams.

[liuche]

data-review+ only, still needs code review

Data Review Form (to be filled by Data Stewards)

1. Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?

yes, will be in metrics.yaml

2. Is there a control mechanism that allows the user to turn the data collection on and off?

Yes, this telemetry is controlled by the Fenix data controls

3. If the request is for permanent data collection, is there someone who will monitor the data over time?

Has expiry

4. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Type 2, interaction with and success of primary password migration

5. Is the data collection request for default-on or default-off?

default on

6. Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?

no

7. Is the data collection covered by the existing Firefox privacy notice?

Yes

8. Does there need to be a check-in in the future to determine whether to renew the data? (Yes/No) (If yes, set a todo reminder or file a bug if appropriate)**

No, expires 3/2021

9. Does the data collection use a third-party collection tool? If yes, escalate to legal.

No

[liuche]

Do we care about:

• number of people who clicked the banner and/or attempted to migrate
• failures to migrate (such as never entering the correct password, or some other failure?)

[ekager]

cc @vesta0 for decision.
Users who clicked the banner is the "displayed" event.
Users who successfully migrated is the "migration" event.
Failures/dismissals are not currently separated.