-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Pin AC TO 57.0.0 and remove feature flag for view downloads #14592
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Can't wait to use the new downloads features!
Codecov Report
@@ Coverage Diff @@
## master #14592 +/- ##
============================================
+ Coverage 30.09% 30.11% +0.01%
- Complexity 1165 1168 +3
============================================
Files 444 444
Lines 17916 17914 -2
Branches 2333 2331 -2
============================================
+ Hits 5392 5394 +2
+ Misses 12148 12145 -3
+ Partials 376 375 -1
Continue to review full report at Codecov.
|
Some failing tests, some that seem unrelated: |
@liuche we see this occasionally with A-C upgrades where some UI tests become unstable. If the test failures are intermittent and seem unrelated to the PR and are blocking, pls give us a heads-up (@AaronMT @sv-ohorvath @rpappalax). It looks like at least settingsMenuBasicsItemsTests may be a genuine failure but we can take a look if this is blocking |
testStrictVisitProtectionSheet ✅ Pushing a PR real quick for * search engine tests broken by #13452 EDIT: thanks rpapa! I'm seeing a couple that are actually broken by removing twitter from the search engine defaults, so I can fix those and then dig into some of the other tests to make sure. Just ran the following original failing tests from my local PR: and updated the other test states. |
lmao maven errors |
🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 |
Finally 🎉 |
…mobile#14592) * Update Android Components version to 57.0.0. * Remove feature flag for "View Downloads". * Update search enginer list from changes by mozilla-mobile#13452 Co-authored-by: Chenxia Liu <liuche@mozilla.com>
Pull Request checklist
To download an APK when reviewing a PR: