Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #14629 - Enable showing frequently visited sites ON by default #14630

Merged
merged 1 commit into from
Sep 8, 2020

Conversation

gabrielluong
Copy link
Member

Fixes #14629

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

Copy link
Contributor

@liuche liuche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this out, turns off nightly flag and sets the default setting to ON

@codecov-commenter
Copy link

codecov-commenter commented Sep 2, 2020

Codecov Report

Merging #14630 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #14630      +/-   ##
============================================
- Coverage     29.76%   29.75%   -0.01%     
+ Complexity     1166     1164       -2     
============================================
  Files           447      447              
  Lines         18135    18134       -1     
  Branches       2355     2355              
============================================
- Hits           5397     5396       -1     
  Misses        12361    12361              
  Partials        377      377              
Impacted Files Coverage Δ Complexity Δ
...pp/src/main/java/org/mozilla/fenix/FeatureFlags.kt 100.00% <ø> (ø) 3.00 <0.00> (-1.00)
.../src/main/java/org/mozilla/fenix/utils/Settings.kt 66.81% <100.00%> (ø) 28.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 100cc7c...707ef9c. Read the comment docs.

@gabrielluong gabrielluong reopened this Sep 2, 2020
@liuche
Copy link
Contributor

liuche commented Sep 2, 2020

verifyRemoveTopSite
@gabrielluong do you think this breaks now that we have frecency turned on by default? I'll re-run these in any case though.

and probably unrelated:
testStrictVisitSheetDetails

And a ton of unit tests failing for some reason 🤔 https://firefoxci.taskcluster-artifacts.net/euFL0hvkT7eEYOTtyWLzUw/0/public/reports/test/testDebugUnitTest/index.html

@liuche liuche closed this Sep 2, 2020
@liuche liuche reopened this Sep 2, 2020
@liuche
Copy link
Contributor

liuche commented Sep 2, 2020

This is actually a test failure that needs to be fixed - we try to remove the wikipedia site but since we visit another site we delete the incorrect site.

@gabrielluong
Copy link
Member Author

We need to wait for AC mozilla-mobile/android-components#8325 to get this test to pass.

@gabrielluong gabrielluong added pr:needs-landing PRs that are ready to land [Will be merged by Mergify] and removed pr:needs-landing PRs that are ready to land [Will be merged by Mergify] labels Sep 8, 2020
@liuche
Copy link
Contributor

liuche commented Sep 8, 2020

We still need #14538 (which should be fixed by #14230), but since we need Top Sites for 81, this is fine to land on Nightly.

@liuche liuche merged commit 7aa6514 into mozilla-mobile:master Sep 8, 2020
@gabrielluong gabrielluong deleted the 14629 branch September 8, 2020 18:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable showing frequently visited sites ON by default
3 participants