-
Notifications
You must be signed in to change notification settings - Fork 1.3k
For #14629 - Enable showing frequently visited sites ON by default #14630
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested this out, turns off nightly flag and sets the default setting to ON
Codecov Report
@@ Coverage Diff @@
## master #14630 +/- ##
============================================
- Coverage 29.76% 29.75% -0.01%
+ Complexity 1166 1164 -2
============================================
Files 447 447
Lines 18135 18134 -1
Branches 2355 2355
============================================
- Hits 5397 5396 -1
Misses 12361 12361
Partials 377 377
Continue to review full report at Codecov.
|
verifyRemoveTopSite and probably unrelated: And a ton of unit tests failing for some reason 🤔 https://firefoxci.taskcluster-artifacts.net/euFL0hvkT7eEYOTtyWLzUw/0/public/reports/test/testDebugUnitTest/index.html |
This is actually a test failure that needs to be fixed - we try to remove the wikipedia site but since we visit another site we delete the incorrect site. |
We need to wait for AC mozilla-mobile/android-components#8325 to get this test to pass. |
Fixes #14629
Pull Request checklist
To download an APK when reviewing a PR: