Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Issue #7620 - Remove Nightly flag for external download manager #14632

Merged
merged 1 commit into from Sep 2, 2020

Conversation

liuche
Copy link
Contributor

@liuche liuche commented Sep 2, 2020

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@liuche liuche requested a review from kglazko September 2, 2020 19:20
@liuche
Copy link
Contributor Author

liuche commented Sep 2, 2020

These failures don't seem related to external download manager:
https://firefoxci.taskcluster-artifacts.net/DdqiIv06T_SlUOvqX-MhOQ/0/public/reports/test/testDebugUnitTest/index.html

and the pre-push hook didn't fail

@liuche liuche closed this Sep 2, 2020
@liuche liuche reopened this Sep 2, 2020
@liuche
Copy link
Contributor Author

liuche commented Sep 2, 2020

Failing on UI test which seems completely unrelated: deleteMultipleSelectionTest
unit test: https://firefoxci.taskcluster-artifacts.net/U_X77hZdRLK3qn6WlMXCJw/0/public/reports/test/testDebugUnitTest/index.html

@liuche liuche closed this Sep 2, 2020
@liuche liuche reopened this Sep 2, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #14632 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #14632      +/-   ##
============================================
- Coverage     29.86%   29.86%   -0.01%     
- Complexity     1165     1167       +2     
============================================
  Files           445      445              
  Lines         18071    18071              
  Branches       2347     2347              
============================================
- Hits           5397     5396       -1     
- Misses        12297    12299       +2     
+ Partials        377      376       -1     
Impacted Files Coverage Δ Complexity Δ
...pp/src/main/java/org/mozilla/fenix/FeatureFlags.kt 100.00% <ø> (ø) 4.00 <0.00> (ø)
...mponents/searchengine/FenixSearchEngineProvider.kt 62.16% <0.00%> (-1.81%) 13.00% <0.00%> (ø%)
...ug/java/org/mozilla/fenix/DebugFenixApplication.kt 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...in/java/org/mozilla/fenix/settings/SupportUtils.kt 74.00% <0.00%> (+4.00%) 13.00% <0.00%> (+2.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81dd1a9...e7d2494. Read the comment docs.

@liuche liuche merged commit 408000e into mozilla-mobile:master Sep 2, 2020
@liuche liuche deleted the download-manager-flag branch September 2, 2020 20:59
liuche added a commit to liuche/fenix that referenced this pull request Sep 2, 2020
liuche added a commit that referenced this pull request Sep 2, 2020
* Issue #7620 - Remove Nightly flag for external download manager (#14632)

* For #14629 - Enable showing frequently visited sites ON by default

* Pin AC to 57.0.1 to pick up new GV 81.0.20200901203141

Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
TrianguloY pushed a commit to TrianguloY/fenix that referenced this pull request Sep 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants