This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
For #14642: Use correct 'Close tabs' summary text for "After one month" #14644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For "closeTabsAfterOneMonth", use the correct summary string of "close_tabs_after_one_month" instead of "close_tabs_after_one_week". This fixes the Settings page "Close tabs" summary showing the wrong tab duration when "Close tabs" is set to "After one month". Closes mozilla-mobile#14642
No Taskcluster jobs started for this pull requestThe `allowPullRequests` configuration for this repository (in `.taskcluster.yml` on the
default branch) does not allow starting tasks for this pull request. |
|
The Mozilla contributing guidelines suggests I should add a reviewer to ensure this is seen, but it seems like the only way a pull request author can do that is via @ekager , when you have the time, would you take a look at this pull request? I think the string change was just a very minor oversight ( And if I shouldn't |
liuche
approved these changes
Sep 2, 2020
liuche
added
the
needs:uplift
|
Good catch! |
|
unrelated flaky tests: |
TrianguloY
pushed a commit
to TrianguloY/fenix
that referenced
this pull request
Sep 3, 2020
…lla-mobile#14644) For "closeTabsAfterOneMonth", use the correct summary string of "close_tabs_after_one_month" instead of "close_tabs_after_one_week". This fixes the Settings page "Close tabs" summary showing the wrong tab duration when "Close tabs" is set to "After one month". Closes mozilla-mobile#14642
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When "Close tabs" is set to "After one month" (
closeTabsAfterOneMonth), use the correct summary string on the Settings page of "After one month" (close_tabs_after_one_month) instead of "After one week" (close_tabs_after_one_week).Closes #14642.
Pull Request checklist
To download an APK when reviewing a PR: