This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
Allow disabling gestures #14708
Merged
Allow disabling gestures #14708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #14708 +/- ##
============================================
- Coverage 29.84% 29.84% -0.01%
+ Complexity 1168 1167 -1
============================================
Files 445 445
Lines 18081 18113 +32
Branches 2346 2349 +3
============================================
+ Hits 5396 5405 +9
- Misses 12309 12332 +23
Partials 376 376
Continue to review full report at Codecov.
|
mcarare
reviewed
Sep 4, 2020
mcarare
approved these changes
Sep 4, 2020
Three new settings and one for which this patch just pre-lands the strings. The behavior for the "Swipe toolbar up to open tabs" is to be added as part of a later ticket.
ekager
reviewed
Sep 9, 2020
| @@ -282,6 +282,8 @@ | |||
| <string name="preferences_theme">Theme</string> | |||
| <!-- Preference for customizing the home screen --> | |||
| <string name="preferences_home">Home</string> | |||
| <!-- Preference for gestures based actions --> | |||
| <string name="preferences_gestures">Gestures</string> | |||
There was a problem hiding this comment.
@betsymi could you confirm these strings? :)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also prelands the Strings needed for #11862
Pull Request checklist
Accessibility Scannerfor the "Customize" settings screen.video showing the changes
To download an APK when reviewing a PR: