Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #15537 - Be more verbose about leanplum identifiers #15538

Merged
merged 6 commits into from
Sep 30, 2020

Conversation

st3fan
Copy link
Contributor

@st3fan st3fan commented Sep 29, 2020

This patch logs the usage of Leanplum identifiers so that it makes it easier to debug #15392 If we think this is low risk then I would like to uplift this patch to 8.1.2 as getting LP messaging working is a very high priority.

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@st3fan st3fan marked this pull request as ready for review September 29, 2020 14:52
@st3fan st3fan requested review from a team as code owners September 29, 2020 14:52
@st3fan st3fan requested a review from boek September 29, 2020 14:52
@codecov-commenter
Copy link

codecov-commenter commented Sep 29, 2020

Codecov Report

Merging #15538 into master will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #15538   +/-   ##
=========================================
  Coverage     29.84%   29.84%           
- Complexity     1180     1182    +2     
=========================================
  Files           452      452           
  Lines         18387    18392    +5     
  Branches       2372     2373    +1     
=========================================
+ Hits           5488     5490    +2     
- Misses        12512    12516    +4     
+ Partials        387      386    -1     
Impacted Files Coverage Δ Complexity Δ
...fenix/components/metrics/LeanplumMetricsService.kt 23.84% <0.00%> (-0.96%) 3.00 <0.00> (ø)
...in/java/org/mozilla/fenix/settings/SupportUtils.kt 74.50% <0.00%> (+3.92%) 13.00% <0.00%> (+2.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fda22e...cf30617. Read the comment docs.

@st3fan st3fan removed the request for review from a team September 29, 2020 17:39
@boek boek closed this Sep 29, 2020
@boek boek reopened this Sep 29, 2020
@st3fan st3fan merged commit ff93017 into master Sep 30, 2020
@bors bors bot deleted the st3fan/15537LeanplumIdentifiers branch September 30, 2020 17:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants