Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #15403 - Adds a secret debug info screen in settings #15540

Merged
merged 2 commits into from
Dec 11, 2020

Conversation

boek
Copy link
Contributor

@boek boek commented Sep 29, 2020

image

This will show the device/user id if they exist

@boek boek requested review from a team as code owners September 29, 2020 16:04
@boek boek closed this Sep 29, 2020
@boek boek reopened this Sep 29, 2020
@codecov-commenter
Copy link

codecov-commenter commented Sep 29, 2020

Codecov Report

Merging #15540 into master will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #15540      +/-   ##
============================================
- Coverage     29.84%   29.82%   -0.02%     
- Complexity     1180     1182       +2     
============================================
  Files           452      453       +1     
  Lines         18387    18406      +19     
  Branches       2372     2376       +4     
============================================
+ Hits           5488     5490       +2     
- Misses        12512    12530      +18     
+ Partials        387      386       -1     
Impacted Files Coverage Δ Complexity Δ
...illa/fenix/settings/SecretDebugSettingsFragment.kt 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...g/mozilla/fenix/settings/SecretSettingsFragment.kt 0.00% <ø> (ø) 0.00 <0.00> (ø)
...ava/org/mozilla/fenix/settings/SettingsFragment.kt 13.50% <0.00%> (-0.26%) 8.00 <0.00> (ø)
...in/java/org/mozilla/fenix/settings/SupportUtils.kt 74.50% <0.00%> (+3.92%) 13.00% <0.00%> (+2.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fda22e...39b902b. Read the comment docs.

Copy link
Contributor

@Amejia481 Amejia481 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

Copy link
Contributor

@eliserichards eliserichards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small nit :)

@boek
Copy link
Contributor Author

boek commented Oct 1, 2020

@eliserichards nits have been fixed, just need the green check :)

Copy link
Member

@gabrielluong gabrielluong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wanted to bump this! I am sure @st3fan will be happy to see this land!

@st3fan
Copy link
Contributor

st3fan commented Oct 13, 2020

Super happy :-)

@gabrielluong gabrielluong added pr:approved PR that has been approved pr:waiting-for-authors PR that has been approved and awaiting any changes before they can land labels Oct 14, 2020
@mergify
Copy link
Contributor

mergify bot commented Nov 20, 2020

This pull request has conflicts when rebasing. Could you fix it @boek? 🙏

Copy link
Contributor

@eliserichards eliserichards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just fixed conflicts with the latest master. Once CI is green this can land and we can make @st3fan happy 😄

@eliserichards eliserichards added pr:needs-landing PRs that are ready to land [Will be merged by Mergify] and removed pr:waiting-for-authors PR that has been approved and awaiting any changes before they can land labels Dec 11, 2020
@codecov-io
Copy link

Codecov Report

Merging #15540 (2de9062) into master (1ca34a2) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #15540      +/-   ##
============================================
- Coverage     30.86%   30.83%   -0.04%     
  Complexity     1239     1239              
============================================
  Files           454      455       +1     
  Lines         18545    18564      +19     
  Branches       2589     2593       +4     
============================================
  Hits           5724     5724              
- Misses        12362    12381      +19     
  Partials        459      459              
Impacted Files Coverage Δ Complexity Δ
...illa/fenix/settings/SecretDebugSettingsFragment.kt 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...g/mozilla/fenix/settings/SecretSettingsFragment.kt 0.00% <ø> (ø) 0.00 <0.00> (ø)
...ava/org/mozilla/fenix/settings/SettingsFragment.kt 13.45% <0.00%> (-0.25%) 8.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ca34a2...2de9062. Read the comment docs.

@eliserichards eliserichards merged commit cf61c10 into mozilla-mobile:master Dec 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:approved PR that has been approved pr:needs-landing PRs that are ready to land [Will be merged by Mergify]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants