-
Notifications
You must be signed in to change notification settings - Fork 1.3k
For #15403 - Adds a secret debug info screen in settings #15540
Conversation
Codecov Report
@@ Coverage Diff @@
## master #15540 +/- ##
============================================
- Coverage 29.84% 29.82% -0.02%
- Complexity 1180 1182 +2
============================================
Files 452 453 +1
Lines 18387 18406 +19
Branches 2372 2376 +4
============================================
+ Hits 5488 5490 +2
- Misses 12512 12530 +18
+ Partials 387 386 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one small nit :)
app/src/main/java/org/mozilla/fenix/settings/SecretDebugSettingsFragment.kt
Outdated
Show resolved
Hide resolved
@eliserichards nits have been fixed, just need the green check :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just wanted to bump this! I am sure @st3fan will be happy to see this land!
app/src/main/java/org/mozilla/fenix/settings/SecretDebugSettingsFragment.kt
Show resolved
Hide resolved
app/src/main/java/org/mozilla/fenix/settings/SecretDebugSettingsFragment.kt
Show resolved
Hide resolved
Super happy :-) |
This pull request has conflicts when rebasing. Could you fix it @boek? 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just fixed conflicts with the latest master
. Once CI is green this can land and we can make @st3fan happy 😄
Codecov Report
@@ Coverage Diff @@
## master #15540 +/- ##
============================================
- Coverage 30.86% 30.83% -0.04%
Complexity 1239 1239
============================================
Files 454 455 +1
Lines 18545 18564 +19
Branches 2589 2593 +4
============================================
Hits 5724 5724
- Misses 12362 12381 +19
Partials 459 459
Continue to review full report at Codecov.
|
This will show the device/user id if they exist