This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nightly automation (without pushapk) #156
Nightly automation (without pushapk) #156
Changes from 4 commits
b78ce1b
d07d5f9
e1a59fd
cdb2c7d
bd94317
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm unsure if we want to index these builds. To me, it feels like unnecessary clutter. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, hold on, is this comment also about staging indexes, or is this one about real nightly indexes?
If it's about staging indexes, I think they might provide some value
If it's about real nightly indexes, I think that they provide just as much value for Fenix as they did Focus and Reference Browser :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same question regarding staging indexes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had them initially in there to make sure that creating the indexes was working properly (at which point, once one build happened, the clutter is now in the indexes permanently).
FWIW, they do have a prefix - when looking for real Fenix nightlies, you can go to
project.mobile.fenix.signed-nightly
and you'll have moved past the clutter.On the whole, I like it when staging builds are as similar as possible to real builds (including indexes). For example, if someone refactors
decision_task_nightly.py
, they can verify after their refactoring that indexes haven't been broken.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense. Let's keep them for now, then. If nobody complains, then let's keep them forever :)
This file was deleted.